★ wanayoo — archive 1999 https://github.com/InnerSourceCommons/InnerSourcePatterns/issues/187Nouvelle recherche | Portail wanayoo
Skip to content

/ InnerSourcePatterns

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adapt PR labels to new contribution process #187

Closed
spier opened this issue Jul 28, 2020 · 6 comments
Closed

Adapt PR labels to new contribution process #187

spier opened this issue Jul 28, 2020 · 6 comments
Labels
Type - Maintenance / Cleanup Type - Meta lookup
Projects
Pattern Working Group

Comments

@spier
Copy link
Contributor

@spier spier commented Jul 28, 2020 •
edited

We have defined new pattern maturity levels as part of the new contribution process.

To make these maturity levels part of our shared language, and to institutionalize our new process, we want to remove the old labels on PRs that we don't use anymore. See https://github.com/InnerSourceCommons/InnerSourcePatterns/pulls

What to do specifically

  • remove the labels 0-Incomplete, 1 - Do 1st Review, and 5-Accepted
  • rename A-Donut to 1-Initial
  • rename B-Unproven to 2-structured
  • rename C-Proven to 3-validated

Side Note

Only an Admin of this repo can do this work!
@spier
Copy link
Contributor Author

@spier spier commented Jul 28, 2020

@maxcapraro can you confirm that these were the label changes that you had in mind?
@spier
Copy link
Contributor Author

@spier spier commented Sep 18, 2020

@lenucksi with Max short on time right now, could you help to clean up these old labels as suggested above? I think they are only confusing right now, as they don't fit our new Maturity Levels anymore. Thanks for your help!
@lenucksi lenucksi moved this from To do to Waiting for reaction / Blocked in Pattern Working Group Sep 21, 2020
@lenucksi lenucksi moved this from Waiting for reaction / Blocked to In progress in Pattern Working Group Sep 21, 2020
@lenucksi
Copy link
Member

@lenucksi lenucksi commented Sep 21, 2020

Moved those. What about 2 - Needs revision 3 - do second review and 4 - finalize looks like those should also be removed.
@spier
Copy link
Contributor Author

@spier spier commented Sep 21, 2020

@lenucksi great catch. Those three can be removed as well. I don't think we are using them right now anyways. We can always introduce new ones if we need them later.

Thanks!
@lenucksi
Copy link
Member

@lenucksi lenucksi commented Sep 22, 2020

Cleaned the remaining unused labels up, this concludes this issue. Closing it.
@lenucksi lenucksi closed this Sep 22, 2020
Pattern Working Group automation moved this from In progress to Done Sep 22, 2020
@lenucksi lenucksi added the lookup label Sep 22, 2020
@spier
Copy link
Contributor Author

@spier spier commented Sep 22, 2020

Awesome, thank you!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Type - Maintenance / Cleanup Type - Meta lookup
Projects
Pattern Working Group
  
Done
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
@spier @lenucksi
You can’t perform that action at this time.