Error when using Settings have ExcludeRules = @() #1063

felixfbecker · 2018-09-03T10:30:12Z

If I pass it a string path to a PSScriptAnalyzerSettings.psd1 file, I get

System.NullReferenceException: Object reference not set to an instance of an object.
   at Microsoft.Windows.PowerShell.ScriptAnalyzer.Settings.GetHashtableFromHashTableAst(HashtableAst hashTableAst)
   at Microsoft.Windows.PowerShell.ScriptAnalyzer.Settings.parseSettingsFile(String settingsFilePath)
   at Microsoft.Windows.PowerShell.ScriptAnalyzer.Settings.Create(Object settingsObj, String cwd, IOutputWriter outputWriter, GetResolvedProviderPathFromPSPath`3 getResolvedProviderPathFromPSPathDelegate)
   at Microsoft.Windows.PowerShell.ScriptAnalyzer.Commands.InvokeFormatterCommand.BeginProcessing()

If I pass it the parsed settings file with Import-PowerShellDataFile, I get

Invoke-Formatter : Cannot parse settings. Will abort the invocation.

Here's my settings file:

@{
    ExcludeRules = @()
    Rules = @{
        PSPlaceOpenBrace = @{
            Enable = $true
            OnSameLine = $true
            NewLineAfter = $true
            IgnoreOneLineBlock = $true
        }

        PSPlaceCloseBrace = @{
            Enable = $true
            NewLineAfter = $false
            IgnoreOneLineBlock = $true
            NoEmptyLineBefore = $true
        }

        PSUseConsistentIndentation = @{
            Enable = $true
            Kind = 'space'
            IndentationSize = 4
        }

        PSUseConsistentWhitespace = @{
            Enable = $true
            CheckOpenBrace = $true
            CheckOpenParen = $true
            CheckOperator = $true
            CheckSeparator = $true
        }

        PSAlignAssignmentStatement = @{
            Enable = $false
        }

        PSUseShouldProcessForStateChangingFunctions = @{
            Enable = $true
        }
    }
}

The same happens with Invoke-ScriptAnalyzer.

felixfbecker · 2018-09-03T10:34:22Z

Ah, this seems to be caused by ExcludeRules = @().

bergmeister · 2018-09-03T22:41:52Z

Thanks for logging this. I am unfortunately still busy this week but I will try to come back to this next week, please remind me should I forget

bergmeister · 2018-09-14T21:21:05Z

I can confirm the bug and will investigate the root cause and hopefully issue a fix in the next few days and yes, I can confirm, it comes from ExcludeRules = @()

felixfbecker changed the title ~~Invoke-Formatter error when using Settings parameter~~ Error when using Settings parameter Sep 3, 2018

felixfbecker changed the title ~~Error when using Settings parameter~~ Error when using Settings have ExcludeRules = @() Sep 3, 2018

bergmeister added the Issue - Bug label Sep 12, 2018

bergmeister mentioned this issue Sep 25, 2018

Fix parsing of empty hashtable when string is provided as settings object #1073

Merged

6 of 7 tasks complete

JamesWTruher closed this in #1073 Oct 3, 2018

PowerShell / PSScriptAnalyzer

Error when using Settings have ExcludeRules = @() #1063

Error when using Settings have ExcludeRules = @() #1063

felixfbecker commented Sep 3, 2018 •

edited

felixfbecker commented Sep 3, 2018

bergmeister commented Sep 3, 2018

bergmeister commented Sep 14, 2018 •

edited

PowerShell / PSScriptAnalyzer

Join GitHub today

Error when using Settings have ExcludeRules = @() #1063

Error when using Settings have ExcludeRules = @() #1063

Comments

felixfbecker commented Sep 3, 2018 • edited

felixfbecker commented Sep 3, 2018

bergmeister commented Sep 3, 2018

bergmeister commented Sep 14, 2018 • edited

felixfbecker commented Sep 3, 2018 •

edited

bergmeister commented Sep 14, 2018 •

edited