★ wanayoo — archive 1999 https://github.com/api-platform/admin/issues/230Nouvelle recherche | Portail wanayoo
Skip to content

/ admin

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate the library to TypeScript #230

Open
dunglas opened this issue Oct 1, 2019 · 5 comments
Open

Migrate the library to TypeScript #230

dunglas opened this issue Oct 1, 2019 · 5 comments
Labels
enhancement hacktoberfest

Comments

@dunglas
Copy link
Member

@dunglas dunglas commented Oct 1, 2019

As React Admin migrated to TypeScript, we should migrate API Platform Admin too. PropTypes definitions must be kept for consumer applications not written in TS.
@instalab
Copy link

@instalab instalab commented Oct 1, 2019

I think I'll claim this task if possible.
I've been working on a bigger JS React projects at work and would like to learn TypeScript now.
@instalab
Copy link

@instalab instalab commented Oct 2, 2019

@dunglas Any additional notes you'd like to add, feel free ;)
@instalab
Copy link

@instalab instalab commented Oct 2, 2019 •
edited

OK just a note from myself, the guys from React Admin haven't migrated fully yet.

I'll probably code this against their next branch
@instalab
Copy link

@instalab instalab commented Oct 4, 2019

@dunglas Do you have Slack?
Could I join if you do?
@dunglas
Copy link
Member Author

@dunglas dunglas commented Oct 4, 2019

@instalab We do! https://api-platform.com/support/
@alanpoulain alanpoulain mentioned this issue Feb 12, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement hacktoberfest
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
@dunglas @instalab
You can’t perform that action at this time.