★ wanayoo — archive 1999 https://github.com/microsoft/vscode-java-debug/issues/454Nouvelle recherche | Portail wanayoo
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Endgame 0.14.0 #454

Closed
testforstephen opened this issue Oct 9, 2018 · 6 comments
Closed

Endgame 0.14.0 #454

testforstephen opened this issue Oct 9, 2018 · 6 comments

Comments

@testforstephen
Copy link
Contributor

@testforstephen testforstephen commented Oct 9, 2018 •

Build

Test

  • 10/10 - Run test plan and verify bugs listed in 0.14.0 plan- @bsaby
  • 10/10 Verify bug fix: Code lenses for Run/Debug links on main methods don't show up immediately @yaohaizh
  • 10/10 Verify bug fix: It throws "ConfigError: 'com.microsoft.app.mymodule/com.microsoft.app.App' is not a valid class name." for java 9 program @yaohaizh
  • 10/10 Verify bug fix: Cannot run from src/test anymore bug @Eskibear
  • 10/10 Verify bug fix: report InvalidStackFrameException during evaluating on conditional breakpoint @Eskibear
  • 10/10 Verify bug fix: The startup command for internalConsole is different from integratedTerminal @Eskibear

Release

  • 10/10 - Add 0.14.0 tag for vscode-java-debug and java-debug - @testforstephen
  • 10/10 - Release to marketplace/Maven Nexus Central Repository/Bintray p2 repository - @testforstephen

Notes

Before you check an item, please reply to this issue with the following details:

What are the steps and details of your check?
What are the configurations?
What are the issues found in the process?
What's your conclusion?

@Eskibear
Copy link
Member

@Eskibear Eskibear commented Oct 10, 2018

Verify bug on Windows

Envs:

Version: 1.27.2 (user setup)
Commit: f46c4c469d6e6d8c46f268d1553c5dc4b475840f
Date: 2018-09-12T16:17:45.060Z
Electron: 2.0.7
Chrome: 61.0.3163.100
Node.js: 8.9.3
V8: 6.1.534.41
Architecture: x64

Cannot run from src/test anymore bug

Test passed.
Related issue: #413
I tried with a simple spring-boot project, adding the main function in DemoApplicationTests.java, and debug it. It fails to load the class in v0.13.0 but works with the private build.

report InvalidStackFrameException during evaluating on conditional breakpoint

Test passed.
Related issue: #369
I modify the main function as mentioned in #369 (comment) , it works with the private build.

The startup command for internalConsole is different from integratedTerminal

Test NOT passed.

  • I cannot set args to "a b \" in VSCode as mentioned in #440 (comment) , it's illegal.
  • For "args": "a b \\" , the args are the same among the 3 types of consoles. But the slash is swallowed.
  • For "args": "a b \"", the args are the same for "internalConsole" and "integratedConsole", but the slash is swallowed. As for "externalConsole", since each arg is wrapped with quote marks, the command line is ...... "a" "b" "". It's strange.
@sallyur
Copy link

@sallyur sallyur commented Oct 10, 2018

Run test plan:

Following https://github.com/Microsoft/vscode-java-debug/blob/master/TestPlan.md

1. Configuration

Windows Mac
Vscode 1.28.0 JDK 8 Vscode1.28.0 JDK 10

2. Open bug: #458

3.Test result:

Test case Windows Mac
Configurations Vscode 1.28.0 JDK 8 Vscode1.28.0 JDK 10
Clean install Pass Pass
Uninstall Pass Pass
Update Pass Pass
HelloWorld Pass Pass
CallStack #458 #458
Multiple Thread Pass Pass
Variables #458 #458
Big stack frame Pass Pass
Breakpoint and inner class Pass Pass
Variable Perform Test Pass Pass
No debug information test Pass Pass
Maven test Pass Pass
Gradle test Pass Pass
PetClinic \ Pass
TODO application Failed (external db issue) Failed (external db issue)
Single file build Pass Pass
Console application Pass Pass
Java 9 modular application Pass \
Multi-root Pass Pass
Step filters Pass Pass
Hot Code Replace Pass Pass
Conditional Breakpoints Pass Pass
Restart Frame Pass Pass
Encoding Test for Project under Chinese directory Pass Pass
Encoding Test for text file encoding #260 Pass
Caught and Uncaught exceptions test Pass Pass
Restart Frame #294 #294
Logpoint Pass Pass
Start without debugging Pass Pass
Environment Variables Pass Pass
Runtime classpath entry Pass Pass
Resolve Variables Pass Pass
Attach evaluation Pass Pass
@sallyur
Copy link

@sallyur sallyur commented Oct 10, 2018 •

Verify bugs:

Features Win10 x64 Mac
Configurations Vscode 1.28.0 JDK 8 Vscode1.28.0 JDK 10
Code lenses for Run/Debug links on main methods don't show up immediately #438 Pass Pass
It throws "ConfigError: 'com.microsoft.app.mymodule/com.microsoft.app.App' is not a valid class name." for java 9 program #437 \ Pass
Cannot run from src/test anymore bug #413 Pass  Pass
report InvalidStackFrameException during evaluating on conditional breakpoint #369 Pass Pass
The startup command for internalConsole is different from integratedTerminal #440 Same result with Yan #454 (comment)  Same result with Yan #454 (comment)
@testforstephen
Copy link
Contributor Author

@testforstephen testforstephen commented Oct 10, 2018

the issue about handling special chars in vmArgs and args is tracked by bug #439.

@testforstephen
Copy link
Contributor Author

@testforstephen testforstephen commented Oct 10, 2018

0.14.0 is released, close it.

@andxu
Copy link
Contributor

@andxu andxu commented Oct 10, 2018 •

@Eskibear It is caused by Java class Runtime.exec(incorrect wrap on special charactors, so it is not able to set args to special character correctly except using tricky way like cmd /c and /bin/sh -c ), and eclipse has the same bugs, bug #439 is to track this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
You can’t perform that action at this time.