★ wanayoo — archive 1999 https://github.com/pichillilorenzo/JavaScriptEnhancements/issues/57Nouvelle recherche | Portail wanayoo
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some default key bindings are overridden by JavaScriptEnhancements #57

Closed
amsul opened this issue May 30, 2018 · 2 comments
Closed

Some default key bindings are overridden by JavaScriptEnhancements #57

amsul opened this issue May 30, 2018 · 2 comments

Comments

@amsul
Copy link

@amsul amsul commented May 30, 2018

Firstly, amazing package @pichillilorenzo! Love the work you've done here 🙇

Now for the small annoyance I've been facing..

Expected Behavior

The default key bindings that Sublime Text uses should work as expected.

Actual Behavior

The following commands are used by Sublime Text:

  • super+alt+w: for changing the search parameters to "whole word"
  • super+alt+s: for saving all unsaved tabs

However, by adding JavaScriptEnhancements, they don't work as it has its own bindings for those keys.

There doesn't seem to be any easy way to remove this option without manually setting it back to the defaults.

Would you consider switching the key bindings to something not already in use?

@pichillilorenzo
Copy link
Owner

@pichillilorenzo pichillilorenzo commented May 30, 2018

Thanks! Keymap changed to super+alt+j and super+alt+h! Now it shouldn't override the default key bindings! I'm going to release a new version with this fix now 👍

@amsul
Copy link
Author

@amsul amsul commented May 30, 2018

@pichillilorenzo awesome! Thanks for handling it so quickly 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.