★ wanayoo — archive 1999 https://github.com/sakuraapi/core/issues/194Nouvelle recherche | Portail wanayoo
Skip to content

/ core

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FromJson should be called on sub documents & Refactor #194

Open
etsuo opened this issue May 14, 2018 · 0 comments
Open

FromJson should be called on sub documents & Refactor #194

etsuo opened this issue May 14, 2018 · 0 comments
Labels
bug enhancement module:@Model
Milestone
next

Comments

@etsuo
Copy link
Member

@etsuo etsuo commented May 14, 2018 •
edited

Part 2 of #177
@FromJson needs to be refactored and updated to behave like @ToJson so that sub document @FromJsons get called.

See: https://github.com/sakuraapi/core/blob/develop/src/core/%40model/from-json.spec.ts#L153
@etsuo etsuo added this to the next milestone May 14, 2018
@etsuo etsuo mentioned this issue May 14, 2018
Closed
2 of 2 tasks complete
@etsuo etsuo modified the milestones: next, 0.17.0 May 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug enhancement module:@Model
Projects
None yet
Milestone
next
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
@etsuo
You can’t perform that action at this time.