Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upOptional database encryption support on database creation. #60
Conversation
|
LGTM. |
cmd/idminer/main.go
Outdated
| log.Fatalf("marshal response failed: %v", err) | ||
| os.Exit(-1) | ||
| return | ||
| } else { |
This comment has been minimized.
This comment has been minimized.
covenantdb
Sep 13, 2018
[golint] reported by reviewdog
if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary)
|
nice! |
codecov
bot
commented
Sep 13, 2018
•
Codecov Report
@@ Coverage Diff @@
## develop #60 +/- ##
===========================================
+ Coverage 76.24% 76.59% +0.35%
===========================================
Files 126 126
Lines 10117 10192 +75
===========================================
+ Hits 7714 7807 +93
+ Misses 1516 1508 -8
+ Partials 887 877 -10 |
cmd/idminer/main.go
Outdated
| log.Fatalf("marshal response failed: %v", err) | ||
| os.Exit(-1) | ||
| return | ||
| } else { |
This comment has been minimized.
This comment has been minimized.
covenantdb
Sep 13, 2018
[golint] reported by reviewdog
if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
xq262144 commentedSep 13, 2018
•
edited
Add several bugfixes including: