★ wanayoo — archive 1999 https://github.com/NativeScript/android-runtime/issues/1554Nouvelle recherche | Portail wanayoo
Skip to content

/ android-runtime

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code cache breaks HMR #1554

Closed
darind opened this issue Dec 12, 2019 · 0 comments
Closed

Code cache breaks HMR #1554

darind opened this issue Dec 12, 2019 · 0 comments
Assignees
@darind
Labels
bug
Milestone
6.3.1

Comments

@darind
Copy link
Member

@darind darind commented Dec 12, 2019

Environment
Provide version numbers for the following components (information can be retrieved by running tns info in your project folder or by inspecting the package.json of the project):

  • CLI: 6.2.2
  • Cross-platform modules: 6.2.3
  • Android Runtime: 6.2.0

Describe the bug

HMR does not work if code cache is enabled

To Reproduce

  1. Enable code cache in app/package.json:
{
  "main": "app.js",
  "android": {
    "v8Flags": "--nolazy --expose_gc",
    "markingMode": "none",
    "codeCache": "true"
  }
}

  1. Run the app: tns run android

  2. Make changes to some of the files and ensure that those changes are applied

  3. Stop the CLI with Ctrl+C

  4. Run the app again without making any changes: tns run android

  5. Make changes to some of the files

Expected behavior

The new changes are applied

Actual behavior

The new changes are never applied on the device even if the CLI reports that those changes have been sent and the app was refreshed.
@darind darind added the bug label Dec 12, 2019
@darind darind self-assigned this Dec 12, 2019
@darind darind mentioned this issue Dec 12, 2019
Open
darind added a commit that referenced this issue Dec 12, 2019
@darind
fix: Ensure js timestamp is smaller than corresponding code cache fil…
Loading status checks…
a6906f1 
…e timestamp (#1554)
@darind darind mentioned this issue Dec 12, 2019
Merged
vmutafov added a commit that referenced this issue Dec 30, 2019
@vmutafov @vtrifonov @darind
Prepare 6.3.1 patch (#1561)
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
4ecdc3c 
* bumping version

* fix(workers): Dispose the isolate when terminating workers (#1550)

* fix: Ensure js timestamp is smaller than corresponding code cache file timestamp (#1554)

* Fix Kotlin enum accessing issue (#1559)

* Update package.json version to 6.3.1

* Update CHANGELOG.md

Co-authored-by: Vasil Trifonov <v.trifonov@gmail.com>
Co-authored-by: Darin Dimitrov <darin.dimitrov@gmail.com>
@vmutafov vmutafov added this to the 6.3.1 milestone Jan 2, 2020
@vmutafov vmutafov closed this Jan 2, 2020
vmutafov added a commit that referenced this issue Jan 31, 2020
@vmutafov @darind @vtrifonov
Merge release into master (#1572)
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
824affb 
* fix(workers): Dispose the isolate when terminating workers (#1550)

* Prepare 6.3.1 patch (#1561)

* bumping version

* fix(workers): Dispose the isolate when terminating workers (#1550)

* fix: Ensure js timestamp is smaller than corresponding code cache file timestamp (#1554)

* Fix Kotlin enum accessing issue (#1559)

* Update package.json version to 6.3.1

* Update CHANGELOG.md

Co-authored-by: Vasil Trifonov <v.trifonov@gmail.com>
Co-authored-by: Darin Dimitrov <darin.dimitrov@gmail.com>

Co-authored-by: Darin Dimitrov <darin.dimitrov@gmail.com>
Co-authored-by: Vasil Trifonov <v.trifonov@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@darind darind

Labels
bug
Projects
None yet
Milestone
6.3.1
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
@darind @vmutafov
You can’t perform that action at this time.