Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd CodeQL Security scanning #1519
Open
Conversation
|
|
||
| - name: Build with dotnet | ||
| run: | | ||
| pwsh -command ./build.ps1 |
This comment has been minimized.
This comment has been minimized.
bergmeister
Jun 11, 2020
Collaborator
We need to do some bootstrapping (platyPS in addition to the .Net Core SDK) before we can build, which would possible also make the setup-dotnet@v1 redundant. pwsh -command doesn't support the usage of semicolons unfortuately
Import-Module .\tools\appveyor.psm1
Invoke-AppveyorInstall -SkipPesterInstallation
./build.ps1 -All
This comment has been minimized.
This comment has been minimized.
jhutchings1
Jun 16, 2020
Author
I made a couple of attempts to fix this feedback, and I could not get it to play nice with codeql. The build seems to be passing and uploading analysis without these steps, though.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
jhutchings1 commentedJun 10, 2020
PR Summary
Hi, I'm a PM on the GitHub security team. This repository is eligible to try the new GitHub Advanced Security code scanning beta.
Code scanning runs a static analysis tool called CodeQL which scans your code at build time to find any potential security issues. We've tuned the set of queries to be only the most severe, most precise issues. We'll show alerts in the security tab, and we'll show alerts for any net new vulnerabilities on pull requests as well. We've tried to make this super developer friendly, but we'd love your feedback as we work through the beta.
If you're interested in trying it out, you can merge this pull request to set up the Actions workflow. You can also get this set up yourself in any additional repositories in this organization by following these instructions
PR Checklist
.cs,.ps1and.psm1files have the correct copyright headerWIP:to the beginning of the title and remove the prefix when the PR is ready.