★ wanayoo — archive 1999 https://github.com/PowerShell/PowerShell/pull/7646Nouvelle recherche | Portail wanayoo
Skip to content

/PowerShell

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to latest package references, runtime framework, and SDK #7646

Merged
merged 4 commits into from Aug 31, 2018
+2,679 −2,549

Conversation

Reviewers

@TravisEz13 TravisEz13

@daxian-dbw daxian-dbw

@SteveL-MSFT SteveL-MSFT

@anmenaga anmenaga

@dantraMSFT dantraMSFT

@adityapatwardhan adityapatwardhan

Assignees

@iSazonov iSazonov

Labels
None yet
Projects
None yet
Milestone
  v6.1.0
2 participants
@iSazonov @TravisEz13
@iSazonov
Copy link
Collaborator

commented Aug 28, 2018

PR Summary

Move to sdk2.1.401, runtime 2.1.3 and update package references.

PR Checklist

@iSazonov iSazonov self-assigned this Aug 28, 2018

@iSazonov iSazonov requested review from daxian-dbw, TravisEz13 and SteveL-MSFT Aug 28, 2018

@iSazonov iSazonov requested review from adityapatwardhan, anmenaga and dantraMSFT as code owners Aug 28, 2018

@iSazonov

This comment has been minimized.

Sign in to view
Copy link
Collaborator Author

commented Aug 28, 2018

CI Appveyor failed with "dotnet : A compatible SDK version for global.json version: [2.1.401] from [C:\projects\powershell\global.json] was not found". I don't know how fix this.

Feel free to add commits.
@TravisEz13

TravisEz13 approved these changes Aug 28, 2018
View changes

@TravisEz13

TravisEz13 requested changes Aug 28, 2018
View changes

Copy link
Member

left a comment

files.wxs is still out of sync
@TravisEz13

This comment has been minimized.

Sign in to view
Copy link
Member

commented Aug 29, 2018

the mac CI was failing due to a version number being in the TMPDIR I was setting. It looks like VSTS has already fixed this issue, so I removed this workaround.
@iSazonov

This comment has been minimized.

Sign in to view
Copy link
Collaborator Author

commented Aug 29, 2018

@TravisEz13 Thanks for help!
I still see the error in CI Appveyor "dotnet : A compatible SDK version for global.json version: [2.1.401] from [C:\projects\powershell\global.json] was not found"
I think it is the reason that file.wxs is not synced.
I don't know how fix CI Appveyor.
@TravisEz13

This comment has been minimized.

Sign in to view
Copy link
Member

commented Aug 29, 2018

That isn't what's causing it to fail. See https://ci.appveyor.com/project/PowerShell/powershell/build/v6.1.0-rc.10858/job/e862tmmuqaww98v0#L1735

iSazonov and others added some commits Aug 28, 2018

@iSazonov @TravisEz13
Move to .Net Core SDK 2.1.401 and runtime 2.1.3
Loading status checks…
4aeaf12
@iSazonov @TravisEz13
Update package references
Loading status checks…
1950ac3
@iSazonov @TravisEz13
Update files.wxs
Loading status checks…
95943a4
@TravisEz13
Add new files to files.wxs
Loading status checks…
74f45f6

@TravisEz13 TravisEz13 force-pushed the iSazonov:move-to-sdk2.1.401 branch to 74f45f6 Aug 31, 2018

@TravisEz13

TravisEz13 approved these changes Aug 31, 2018
View changes

@TravisEz13 TravisEz13 merged commit c34d3ef into PowerShell:master Aug 31, 2018
8 checks passed

8 checks passed

CodeFactor No issues found.
Details
PowerShell-CI-linux #PR-7646-20180831.02 succeeded with issues
Details
PowerShell-CI-macos #PR-7646-20180831.02 succeeded
Details
PowerShell-CI-windows #PR-7646-20180831.02 succeeded
Details
WIP ready for review
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla All CLA requirements met.
Details
@iSazonov

This comment has been minimized.

Sign in to view
Copy link
Collaborator Author

commented Aug 31, 2018

@TravisEz13 Thanks for help!

@iSazonov iSazonov deleted the iSazonov:move-to-sdk2.1.401 branch Aug 31, 2018

@TravisEz13

This comment has been minimized.

Sign in to view
Copy link
Member

commented Aug 31, 2018

@iSazonov No problem... I used this to test my new code to generate the wxs file changes.

TravisEz13 added a commit that referenced this pull request Aug 31, 2018

@iSazonov @TravisEz13
Update to latest package references, runtime framework, and SDK (#7646) 
* Move to .Net Core SDK 2.1.401 and runtime 2.1.3

* Update package references
Loading status checks…
959ce30

@TravisEz13 TravisEz13 added this to the v6.1.0 milestone Aug 31, 2018

@iSazonov iSazonov referenced this pull request Sep 6, 2018

Merged

Update PSReadLine to 2.0.0-beta3 #7711

7 of 11 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.