Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign upFix file blocking issue with webcmdlets #7676
+1
−1
Conversation
Claustn
requested review from
dantraMSFT,
JamesWTruher and
PaulHigin
as
code owners
Aug 31, 2018
Claustn
referenced this pull request
Aug 31, 2018
Closed
Webcmdlets using -InFile parameter locks file #7669
iSazonov
requested a review
from
markekraus
Aug 31, 2018
iSazonov
self-assigned this
Aug 31, 2018
iSazonov
changed the title
Fix file blocking issue with webcmdlets using -InFile Issue #7669
Fix file blocking issue with webcmdlets
Aug 31, 2018
This comment has been minimized.
This comment has been minimized.
|
@Claustn Thanks! I slightly corrected the PR title and description. |
iSazonov
approved these changes
Aug 31, 2018
iSazonov
requested a review
from
SteveL-MSFT
Aug 31, 2018
This comment has been minimized.
This comment has been minimized.
|
@Claustn Please rename your commit - start title with |
This comment has been minimized.
This comment has been minimized.
|
CI Appveyor temporary failed. |
markekraus
reviewed
Aug 31, 2018
|
LGTM. My approval is pending successful completion of all |
Claustn
force-pushed the
Claustn:fix/webcmdlets_infile_blocking
branch
to
5f70274
Sep 1, 2018
iSazonov
merged commit eb92b14
into
PowerShell:master
Sep 1, 2018
8 checks passed
CodeFactor
No issues found.
Details
PowerShell-CI-linux
#PR-7676-20180901.02 succeeded with issues
Details
PowerShell-CI-macos
#PR-7676-20180901.02 succeeded
Details
PowerShell-CI-windows
#PR-7676-20180901.02 succeeded
Details
WIP
ready for review
Details
continuous-integration/appveyor/pr
AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr
The Travis CI build passed
Details
license/cla
All CLA requirements met.
This comment has been minimized.
This comment has been minimized.
|
@Claustn Thanks for discovering the issue and fixing it! |
TravisEz13
added a commit
that referenced
this pull request
Sep 5, 2018
TravisEz13
added this to the v6.1.0 milestone
Sep 7, 2018
thezim
referenced this pull request
Oct 1, 2018
Closed
Bug: Add-Type needs write-access when compiling from source #7914
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Claustn commentedAug 31, 2018
•
edited by iSazonov
PR Summary
Resolve #7669.
Allows multiple uploads of the same file in parallel
This PR changes how -InFile parameter on the Web cmdlets open file handles. Previously the file was opened with ShareAccess None, meaning that the file was locked, resulting in that you, for instance, was not able to upload the same file to multiple destinations in parallel.
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:to the beginning of the title and remove the prefix when the PR is ready.[feature]if the change is significant or affects feature tests