Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign upUpdate version of SDK in hosting.tests.csproj for powershell release 6.1.0 #7751
+1
−1
Conversation
adityapatwardhan
assigned
TravisEz13
Sep 10, 2018
adityapatwardhan
requested a review
from
TravisEz13
Sep 10, 2018
adityapatwardhan
requested review from
anmenaga,
dantraMSFT and
daxian-dbw
as
code owners
Sep 10, 2018
adityapatwardhan
changed the title
Update version for powershell release 6.1.0
Update version of SDK in hosting.tests.csproj for powershell release 6.1.0
Sep 10, 2018
anmenaga
approved these changes
Sep 10, 2018
TravisEz13
approved these changes
Sep 10, 2018
TravisEz13
merged commit 2e30699
into
PowerShell:master
Sep 10, 2018
3 of 7 checks passed
PowerShell-CI-linux
in progress
Details
PowerShell-CI-macos
queued
Details
PowerShell-CI-windows
in progress
Details
continuous-integration/appveyor/pr
Waiting for AppVeyor build to complete
Details
CodeFactor
No issues found.
Details
WIP
ready for review
Details
license/cla
All CLA requirements met.
TravisEz13
added a commit
that referenced
this pull request
Sep 10, 2018
TravisEz13
added this to the v6.1.0 milestone
Sep 10, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
adityapatwardhan commentedSep 10, 2018
•
edited
PR Summary
The version for the SDK should be the version we want to test for the release.
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:to the beginning of the title and remove the prefix when the PR is ready.[feature]if the change is significant or affects feature tests