Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign upFix .NET adapter to not throw when fails to create a PSMethod due to ByRef-like type #7788
+21
−9
Conversation
daxian-dbw
requested review from
BrucePay and
adityapatwardhan
Sep 14, 2018
iSazonov
approved these changes
Sep 17, 2018
daxian-dbw
self-assigned this
Sep 17, 2018
daxian-dbw
merged commit 285e471
into
PowerShell:master
Sep 17, 2018
8 checks passed
CodeFactor
No issues found.
Details
PowerShell-CI-linux
#PR-7788-20180914.01 succeeded
Details
PowerShell-CI-macos
#PR-7788-20180914.01 succeeded
Details
PowerShell-CI-spelling
#PR-7788-20180914.01 succeeded
Details
PowerShell-CI-windows
#PR-7788-20180914.01 succeeded
Details
WIP
ready for review
Details
continuous-integration/appveyor/pr
AppVeyor build succeeded
Details
license/cla
All CLA requirements met.
Details
daxian-dbw
deleted the
daxian-dbw:bugfix
branch
Sep 17, 2018
iSazonov
referenced this pull request
Jan 28, 2019
Open
Formatter throws when object has a pointer property #8765
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
daxian-dbw commentedSep 14, 2018
•
edited by adityapatwardhan
PR Summary
Fix #7786
When embedding signatures of the overload methods into a
PSMethod, we don't handle ByRef-like types -- overload methods with ByRef-like type parameters will be marked as 'NonBindable' and get ignored in the conversion fromPSMethodtoDelegate. This PR fix a bug that causes exception to be thrown when dealing with a ByRef-like type being used by areforoutparameter./cc @SeeminglyScience
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:to the beginning of the title and remove the prefix when the PR is ready.[feature]if the change is significant or affects feature tests