★ wanayoo — archive 1999 https://github.com/PowerShell/PowerShell/pull/7831Nouvelle recherche | Portail wanayoo
Skip to content

/PowerShell

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update PowerShellGet to 2.0.0 #7831

Merged
merged 2 commits into from Sep 24, 2018
+10 −10

Conversation

Reviewers

@anmenaga anmenaga

@adityapatwardhan adityapatwardhan

@daxian-dbw daxian-dbw

@TravisEz13 TravisEz13

Assignees

@TravisEz13 TravisEz13

@adityapatwardhan adityapatwardhan

Labels
CL-BuildPackaging
Projects
None yet
Milestone
No milestone
6 participants
@SteveL-MSFT @anmenaga @adityapatwardhan @TravisEz13 @daxian-dbw @bmanikm
@SteveL-MSFT
Copy link
Member

commented Sep 20, 2018 •
edited

PR Summary

Update version of PowerShellGet to 2.0.0

PR Checklist

@SteveL-MSFT SteveL-MSFT assigned adityapatwardhan Sep 20, 2018

@SteveL-MSFT SteveL-MSFT requested a review from adityapatwardhan Sep 20, 2018

@SteveL-MSFT SteveL-MSFT requested review from anmenaga, daxian-dbw and TravisEz13 as code owners Sep 20, 2018

@anmenaga

This comment has been minimized.

Sign in to view
Copy link
Contributor

commented Sep 20, 2018 •
edited

I think @TravisEz13 mentioned to me that there is some functionality in VSTS to detect these things (updated dependency versions)...
@anmenaga

anmenaga approved these changes Sep 20, 2018
View changes

@adityapatwardhan

This comment has been minimized.

Sign in to view
Copy link
Member

commented Sep 20, 2018

PackageManagement tests are part of Feature tests. Please push an empty commit with [Feature].

@SteveL-MSFT SteveL-MSFT force-pushed the SteveL-MSFT:psget-20 branch Sep 20, 2018

@TravisEz13

This comment has been minimized.

Sign in to view
Copy link
Member

commented Sep 20, 2018

It looks like the PowerShellGet tests need to be updated.
@SteveL-MSFT

This comment has been minimized.

Sign in to view
Copy link
Member Author

commented Sep 20, 2018

@bmanikm can you look at the test failures?
@daxian-dbw

This comment has been minimized.

Sign in to view
Copy link
Member

commented Sep 21, 2018

The Package Reference from package.tests.ps1 fails because NJsonSchema updates the revision number again. The revision number is incremented about every week.

I updated to the latest review in PR #7834. At the same time, we need to think about how to not get interrupted too much by this special package.
@SteveL-MSFT

This comment has been minimized.

Sign in to view
Copy link
Member Author

commented Sep 21, 2018

@daxian-dbw should we special case NJsonSchema to only look at major.minor?
@bmanikm

This comment has been minimized.

Sign in to view
Copy link
Contributor

commented Sep 21, 2018

@SteveL-MSFT I have updated the PowerShellGet tests, it looks like the new test failures are not related to PowerShellGet, please take a look at the new test failures.

@TravisEz13 TravisEz13 self-assigned this Sep 21, 2018

@TravisEz13 TravisEz13 force-pushed the SteveL-MSFT:psget-20 branch Sep 21, 2018

@TravisEz13

This comment has been minimized.

Sign in to view
Copy link
Member

commented Sep 21, 2018

rebased the PR to pick up fixes for test failures

SteveL-MSFT and others added some commits Sep 20, 2018

@SteveL-MSFT @adityapatwardhan
[feature] 
update PSGet to 2.0.0
Loading status checks…
6ab337d
@bmanikm @adityapatwardhan
[Feature] Update PowerShellGet tests as per PowerShellGet 2.0.0 changes
Loading status checks…
7de2720

@adityapatwardhan adityapatwardhan force-pushed the SteveL-MSFT:psget-20 branch to 7de2720 Sep 24, 2018

@adityapatwardhan

This comment has been minimized.

Sign in to view
Copy link
Member

commented Sep 24, 2018

Rebase and pushed to update package references.
@adityapatwardhan

adityapatwardhan approved these changes Sep 24, 2018
View changes

@adityapatwardhan adityapatwardhan merged commit 769ba7b into PowerShell:master Sep 24, 2018
8 checks passed

8 checks passed

CodeFactor No issues found.
Details
PowerShell-CI-linux #PR-7831-20180924.01 succeeded
Details
PowerShell-CI-macos #PR-7831-20180924.01 succeeded
Details
PowerShell-CI-spelling #PR-7831-20180924.01 succeeded
Details
PowerShell-CI-windows #PR-7831-20180924.01 succeeded
Details
WIP ready for review
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
license/cla All CLA requirements met.
Details

@adityapatwardhan adityapatwardhan added the CL-BuildPackaging label Feb 14, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.