Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign upUpdating incorrect example of PowerShell.Create() #7926
+1
−1
Conversation
This comment has been minimized.
This comment has been minimized.
|
Took some digging to find this, but it looks like Docs.Microsoft.Com scrapes files like these to generate the code samples. The intention is that this change:
|
1RedOne
requested review from
BrucePay and
daxian-dbw
as
code owners
Oct 2, 2018
iSazonov
requested a review
from
SteveL-MSFT
Oct 3, 2018
iSazonov
self-assigned this
Oct 3, 2018
SteveL-MSFT
approved these changes
Oct 3, 2018
|
Great find! Thanks! |
iSazonov
merged commit 0789fb1
into
PowerShell:master
Oct 3, 2018
8 checks passed
CodeFactor
No issues found.
Details
PowerShell-CI-linux
#PR-7926-20181002.01 succeeded
Details
PowerShell-CI-macos
#PR-7926-20181002.01 succeeded
Details
PowerShell-CI-spelling
#PR-7926-20181002.01 succeeded
Details
PowerShell-CI-windows
#PR-7926-20181002.01 succeeded
Details
WIP
ready for review
Details
continuous-integration/appveyor/pr
AppVeyor build succeeded
Details
license/cla
All CLA requirements met.
adityapatwardhan
pushed a commit
to adityapatwardhan/PowerShell
that referenced
this pull request
Apr 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
1RedOne commentedOct 2, 2018
•
edited by iSazonov
Updating this documentation, per this issue in Github. MicrosoftDocs/PowerShell-Docs#2938
The overload for powerShell.Create() are either RunSpaceMode, or InitialSessionState. In order to accept a command, one must use the .AddScript method.
PR Summary
Took some digging to find this, but it looks like Docs.Microsoft.Com scrapes files like these to generate the code samples.
The intention is that this change:
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:to the beginning of the title and remove the prefix when the PR is ready.[feature]if the change is significant or affects feature tests