★ wanayoo — archive 1999 https://github.com/PowerShell/PowerShell/pull/7926Nouvelle recherche | Portail wanayoo
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating incorrect example of PowerShell.Create() #7926

Merged
merged 1 commit into from Oct 3, 2018

Conversation

Projects
None yet
3 participants
@1RedOne
Copy link
Contributor

commented Oct 2, 2018 •

Updating this documentation, per this issue in Github. MicrosoftDocs/PowerShell-Docs#2938

The overload for powerShell.Create() are either RunSpaceMode, or InitialSessionState. In order to accept a command, one must use the .AddScript method.

PR Summary

Took some digging to find this, but it looks like Docs.Microsoft.Com scrapes files like these to generate the code samples.

The intention is that this change:

PR Checklist

Updating incorrect example of PowerShell.Create()
Updating this documentation, per this issue in Github.  MicrosoftDocs/PowerShell-Docs#2938 

The overload for powerShell.Create() are either RunSpaceMode, or InitialSessionState.  In order to accept a command, one must use the .AddScript method.
@1RedOne

This comment has been minimized.

Copy link
Contributor Author

commented on b2ea655 Oct 2, 2018

Took some digging to find this, but it looks like Docs.Microsoft.Com scrapes files like these to generate the code samples.

The intention is that this change:

  1. Should happen, as it appears to be incorrect as is today in the comments
  2. Hopefully will drive an update to this page as well - https://docs.microsoft.com/en-us/dotnet/api/system.management.automation.powershell?view=pscore-6.0.0

@1RedOne 1RedOne requested review from BrucePay and daxian-dbw as code owners Oct 2, 2018

@iSazonov iSazonov requested a review from SteveL-MSFT Oct 3, 2018

@iSazonov iSazonov self-assigned this Oct 3, 2018

@SteveL-MSFT
Copy link
Member

left a comment

Great find! Thanks!

@iSazonov iSazonov merged commit 0789fb1 into PowerShell:master Oct 3, 2018

8 checks passed

CodeFactor No issues found.
Details
PowerShell-CI-linux #PR-7926-20181002.01 succeeded
Details
PowerShell-CI-macos #PR-7926-20181002.01 succeeded
Details
PowerShell-CI-spelling #PR-7926-20181002.01 succeeded
Details
PowerShell-CI-windows #PR-7926-20181002.01 succeeded
Details
WIP ready for review
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
license/cla All CLA requirements met.

adityapatwardhan pushed a commit to adityapatwardhan/PowerShell that referenced this pull request Apr 9, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.