★ wanayoo — archive 1999 https://github.com/PowerShell/PowerShell/pull/7978Nouvelle recherche | Portail wanayoo
Skip to content

/PowerShell

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #7978

Merged
merged 1 commit into from Nov 1, 2018

Conversation

Reviewers

@adityapatwardhan adityapatwardhan

@TravisEz13 TravisEz13

@anmenaga anmenaga

@SteveL-MSFT SteveL-MSFT

Assignees

@adityapatwardhan adityapatwardhan

Labels
None yet
Projects
None yet
Milestone
No milestone
7 participants
@iGotenz @anmenaga @RDIL @adityapatwardhan @iSazonov @TravisEz13 @SteveL-MSFT
@iGotenz
Copy link
Contributor

commented Oct 9, 2018 •
edited by iSazonov

PR Summary

Simple grammatical correction in README.md file.

PR Checklist
@iGotenz
Update README.md
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
3ad48d7
@SteveL-MSFT

SteveL-MSFT reviewed Oct 9, 2018
View changes

Copy link
Member

left a comment

I don't believe this PR provides much value. The current content is fine.
@anmenaga

This comment has been minimized.

Sign in to view
Copy link
Contributor

commented Oct 10, 2018

@SteveL-MSFT I actually think that PR provides more value than what is listed in the 'Files changes'. Something we discussed previously.

@SteveL-MSFT SteveL-MSFT dismissed their stale review Oct 10, 2018

Deferring to Andrew to review

@RDIL

This comment has been minimized.

Sign in to view
Copy link
Contributor

commented Oct 10, 2018

I think this is the only one that makes more sense:

  • If you already cloned but forgot to use --recursive, you can update submodules manually:
  • If you have already cloned but forgot to use --recursive, you can update submodules manually:
@anmenaga

anmenaga approved these changes Oct 11, 2018
View changes

@TravisEz13

TravisEz13 approved these changes Oct 19, 2018
View changes

README.md
@@ -194,7 +194,7 @@ To make things easy, you can just clone recursively:
git clone --recursive https://github.com/PowerShell/PowerShell.git

This comment has been minimized.

Sign in to view
Copy link
@TravisEz13

TravisEz13 Oct 19, 2018

Member

--recursive is not needed anymore.

Do you want to fix this or merge as is?

This comment has been minimized.

Sign in to view
Copy link
@adityapatwardhan

adityapatwardhan Oct 29, 2018

Member

I would like this to be removed as --recursive is not needed anymore.

@anmenaga anmenaga assigned adityapatwardhan Oct 26, 2018

@adityapatwardhan

This comment has been minimized.

Sign in to view
Copy link
Member

commented Oct 29, 2018

@iGotenz Please fill the PR template above, it helps us create change logs.

@iSazonov iSazonov assigned iSazonov and adityapatwardhan and unassigned adityapatwardhan and iSazonov Nov 1, 2018

@iSazonov

This comment has been minimized.

Sign in to view
Copy link
Collaborator

commented Nov 1, 2018

@adityapatwardhan I updated the PR description.

@TravisEz13 TravisEz13 merged commit c5c747c into PowerShell:master Nov 1, 2018
7 checks passed

7 checks passed

PowerShell-CI-linux #PR-7978-20181009.01 succeeded
Details
PowerShell-CI-macos #PR-7978-20181009.01 succeeded
Details
PowerShell-CI-spelling #PR-7978-20181009.01 succeeded
Details
PowerShell-CI-windows #PR-7978-20181009.01 succeeded
Details
WIP Legacy commit status override — see details
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
license/cla All CLA requirements met.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.