Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd a path for checking ZoneInformation without throwing an exception #8025
+77
−54
Conversation
powercode
requested review from
anmenaga and
BrucePay
as
code owners
Oct 14, 2018
iSazonov
reviewed
Oct 16, 2018
| { | ||
| string errorMessage = StringUtil.Format( | ||
| FileSystemProviderStrings.AlternateDataStreamNotFound, streamName, path); | ||
| throw new FileNotFoundException(errorMessage, resultPath); | ||
| throw new FileNotFoundException(errorMessage, $"{path}:{streamName.Trim()}"); |
This comment has been minimized.
This comment has been minimized.
iSazonov
Oct 16, 2018
Collaborator
Do we really need Trim() for streamName in the internal methods? We do not this for path.
This comment has been minimized.
This comment has been minimized.
powercode
Oct 16, 2018
Author
Collaborator
Not sure - I just opted to not change any functionality. Small cost on the error path.
This comment has been minimized.
This comment has been minimized.
iSazonov
added some commits
Oct 17, 2018
iSazonov
approved these changes
Oct 23, 2018
iSazonov
requested review from
adityapatwardhan and
SteveL-MSFT
Oct 23, 2018
iSazonov
self-assigned this
Oct 23, 2018
anmenaga
approved these changes
Oct 23, 2018
iSazonov
merged commit 3e4fa87
into
PowerShell:master
Oct 24, 2018
8 checks passed
CodeFactor
6 issues fixed.
Details
PowerShell-CI-linux
#PR-8025-20181018.01 succeeded
Details
PowerShell-CI-macos
#PR-8025-20181018.01 succeeded
Details
PowerShell-CI-spelling
#4139 succeeded
Details
PowerShell-CI-windows
#PR-8025-20181018.01 succeeded
Details
WIP
ready for review
Details
continuous-integration/appveyor/pr
AppVeyor build succeeded
Details
license/cla
All CLA requirements met.
Details
adityapatwardhan
pushed a commit
to adityapatwardhan/PowerShell
that referenced
this pull request
Apr 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
powercode commentedOct 14, 2018
•
edited by iSazonov
PR Summary
In an effort to reduce the number of exceptions we throw as standard flowcontrol, this PR adds
as a non-throwing alternative to
CreateFileStream.This makes the code slightly faster and debugging slightly less annoying.
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:to the beginning of the title and remove the prefix when the PR is ready.[feature]if the change is significant or affects feature tests