★ wanayoo — archive 1999 https://github.com/PowerShell/PowerShell/pull/8128Nouvelle recherche | Portail wanayoo
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable case-insensitive tab completion for files and folders on case-sensitive filesystem #8128

Merged
merged 6 commits into from Oct 28, 2018

Conversation

Projects
None yet
2 participants
@SteveL-MSFT
Copy link
Member

commented Oct 26, 2018 •

PR Summary

Leverage new EnumerationOption in .NET Core 2.1 to have case-insensitive enumeration of files and folders. Allows for case-insensitive tab completion of files and folders on a case-sensitive filesystem.

#1273

PR Checklist

@SteveL-MSFT SteveL-MSFT force-pushed the SteveL-MSFT:case-insensitive-completion branch Oct 26, 2018

[feature]
need to explicitly have enumoptions not skip hidden/system files to retain existing behavior

@SteveL-MSFT SteveL-MSFT force-pushed the SteveL-MSFT:case-insensitive-completion branch to 5db5590 Oct 26, 2018

@iSazonov
Copy link
Collaborator

left a comment

Great PR!

Show resolved Hide resolved ...m.Management.Automation/engine/CommandCompletion/CompletionCompleters.cs Outdated
Show resolved Hide resolved src/System.Management.Automation/namespaces/FileSystemProvider.cs Outdated
Show resolved Hide resolved test/powershell/Host/TabCompletion/TabCompletion.Tests.ps1 Outdated
}

It "Test case insensitive folder path" -Skip:(!$IsLinux) {
$testDirs = "AA", "Aa", "aa"

This comment has been minimized.

Copy link
@iSazonov

iSazonov Oct 26, 2018

Collaborator

We could check dirs in previous test with files.

@SteveL-MSFT SteveL-MSFT force-pushed the SteveL-MSFT:case-insensitive-completion branch to 07b18e4 Oct 26, 2018

@SteveL-MSFT SteveL-MSFT force-pushed the SteveL-MSFT:case-insensitive-completion branch to a5b5889 Oct 26, 2018

Update test/powershell/Host/TabCompletion/TabCompletion.Tests.ps1
Co-Authored-By: SteveL-MSFT <slee@microsoft.com>

@iSazonov iSazonov merged commit b27380d into PowerShell:master Oct 28, 2018

7 checks passed

CodeFactor No issues found.
Details
PowerShell-CI-linux #4691 succeeded
Details
PowerShell-CI-macos #PR-8128-20181027.01 succeeded
Details
PowerShell-CI-spelling #PR-8128-20181027.01 succeeded
Details
PowerShell-CI-windows #PR-8128-20181027.01 succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
license/cla All CLA requirements met.
Details
@iSazonov

This comment has been minimized.

Copy link
Collaborator

commented Oct 28, 2018

@SteveL-MSFT Should we close #1273?

@SteveL-MSFT SteveL-MSFT deleted the SteveL-MSFT:case-insensitive-completion branch Oct 28, 2018

@iSazonov iSazonov added the CL-General label Jan 17, 2019

adityapatwardhan pushed a commit to adityapatwardhan/PowerShell that referenced this pull request Apr 9, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.