★ wanayoo — archive 1999 https://github.com/PowerShell/PowerShell/pull/8190Nouvelle recherche | Portail wanayoo
Skip to content

/PowerShell

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup assemblyinfo #8190

Merged
merged 5 commits into from Nov 16, 2018

Conversation

Reviewers

@anmenaga anmenaga

@adityapatwardhan adityapatwardhan

@TravisEz13 TravisEz13

@daxian-dbw daxian-dbw

@SteveL-MSFT SteveL-MSFT

Assignees

@TravisEz13 TravisEz13

Labels
CL-CodeCleanup
Projects
None yet
Milestone
No milestone
4 participants
@iSazonov @anmenaga @adityapatwardhan @TravisEz13
@iSazonov
Copy link
Collaborator

commented Nov 6, 2018 •
edited

PR Summary

Remove old code from AssemblyInfo.cs

Additional considerations

We could use IgnoreAccessChecksToAttribute instead of InternalsVisibleToAttribute.

PR Checklist

@iSazonov iSazonov requested review from daxian-dbw, TravisEz13 and SteveL-MSFT Nov 6, 2018

@iSazonov iSazonov requested a review from anmenaga as a code owner Nov 6, 2018

@iSazonov iSazonov force-pushed the iSazonov:cleanup-assemblyinfo branch to 1172f95 Nov 6, 2018

@iSazonov

This comment has been minimized.

Sign in to view
Copy link
Collaborator Author

commented Nov 6, 2018

Seems Appveyor CI temporary failed.
@anmenaga

This comment has been minimized.

Sign in to view
Copy link
Contributor

commented Nov 6, 2018

Restarted AppVeyor build.
@anmenaga

anmenaga reviewed Nov 8, 2018
View changes

src/Microsoft.Management.Infrastructure.CimCmdlets/AssemblyInfo.cs Outdated
using System.Reflection;
using System.Runtime.CompilerServices;

[assembly:InternalsVisibleTo("Microsoft.Windows.DSC.CoreConfProviders,PublicKey=0024000004800000940000000602000000240000525341310004000001000100b5fc90e7027f67871e773a8fde8938c81dd402ba65b9201d60593e96c492651e889cc13f1415ebb53fac1131ae0bd333c5ee6021672d9718ea31a8aebd0da0072f25d87dba6fc90ffd598ed4da35e44c398c454307e8e33b8426143daec9f596836f97c8f74750e5975c64e2189f45def46b2a2b1247adc3652bf5c308055da9")]

This comment has been minimized.

Sign in to view
Copy link
@anmenaga

anmenaga Nov 8, 2018

Contributor

how do you know that this is not used?

This comment has been minimized.

Sign in to view
Copy link
@iSazonov

iSazonov Nov 8, 2018

Author Collaborator

I don't know. It is for MSFT review.
I believe that internal and private visibility is permissible only in the repo. All other should use only public APIs or IgnoreAccessChecksToAttribute if needed.

This comment has been minimized.

Sign in to view
Copy link
@TravisEz13

TravisEz13 Nov 9, 2018

Member

I'll email DSC and ask.

This comment has been minimized.

Sign in to view
Copy link
@TravisEz13

TravisEz13 Nov 9, 2018

Member

I verified the DSC team still needs this.
@TravisEz13

TravisEz13 requested changes Nov 9, 2018
View changes

Copy link
Member

left a comment

Add DSC intervals visible to back
@iSazonov

This comment has been minimized.

Sign in to view
Copy link
Collaborator Author

commented Nov 10, 2018

@TravisEz13 Will do.
Could you please share why they need the visibility?
If they use it only for tests with precompiled dlls from the repo and use Roslyn they could migrate to using IgnoreAccessChecksToAttribute. Of cause if they still use old test system we have to keep the visibility for them.
@iSazonov
Revert visibility to DSC
Loading status checks…
218f21d
@adityapatwardhan

This comment has been minimized.

Sign in to view
Copy link
Member

commented Nov 12, 2018

@iSazonov Please push a commit with [Feature] tag to execute all tests.
@iSazonov
[Feature]
Loading status checks…
4c040be
@iSazonov

This comment has been minimized.

Sign in to view
Copy link
Collaborator Author

commented Nov 13, 2018

@TravisEz13 Please update your review.
@TravisEz13

This comment has been minimized.

Sign in to view
Copy link
Member

commented Nov 14, 2018

They do use the visibility for testing, but some of it is legacy.
@TravisEz13

TravisEz13 reviewed Nov 14, 2018
View changes

src/System.Management.Automation/AssemblyInfo.cs
[assembly: InternalsVisibleTo(@"Microsoft.PowerShell.GPowerShell" + @",PublicKey=0024000004800000940000000602000000240000525341310004000001000100b5fc90e7027f67871e773a8fde8938c81dd402ba65b9201d60593e96c492651e889cc13f1415ebb53fac1131ae0bd333c5ee6021672d9718ea31a8aebd0da0072f25d87dba6fc90ffd598ed4da35e44c398c454307e8e33b8426143daec9f596836f97c8f74750e5975c64e2189f45def46b2a2b1247adc3652bf5c308055da9")]
[assembly: InternalsVisibleTo(@"Microsoft.PowerShell.ISECommon" + @",PublicKey=0024000004800000940000000602000000240000525341310004000001000100b5fc90e7027f67871e773a8fde8938c81dd402ba65b9201d60593e96c492651e889cc13f1415ebb53fac1131ae0bd333c5ee6021672d9718ea31a8aebd0da0072f25d87dba6fc90ffd598ed4da35e44c398c454307e8e33b8426143daec9f596836f97c8f74750e5975c64e2189f45def46b2a2b1247adc3652bf5c308055da9")]
[assembly: InternalsVisibleTo(@"Microsoft.PowerShell.Editor" + @",PublicKey=0024000004800000940000000602000000240000525341310004000001000100b5fc90e7027f67871e773a8fde8938c81dd402ba65b9201d60593e96c492651e889cc13f1415ebb53fac1131ae0bd333c5ee6021672d9718ea31a8aebd0da0072f25d87dba6fc90ffd598ed4da35e44c398c454307e8e33b8426143daec9f596836f97c8f74750e5975c64e2189f45def46b2a2b1247adc3652bf5c308055da9")]
[assembly: InternalsVisibleTo(@"powershell_ise" + @",PublicKey=0024000004800000940000000602000000240000525341310004000001000100b5fc90e7027f67871e773a8fde8938c81dd402ba65b9201d60593e96c492651e889cc13f1415ebb53fac1131ae0bd333c5ee6021672d9718ea31a8aebd0da0072f25d87dba6fc90ffd598ed4da35e44c398c454307e8e33b8426143daec9f596836f97c8f74750e5975c64e2189f45def46b2a2b1247adc3652bf5c308055da9")]

This comment has been minimized.

Sign in to view
Copy link
@TravisEz13

TravisEz13 Nov 14, 2018

Member

Do we know why this was here?

This comment has been minimized.

Sign in to view
Copy link
@iSazonov

iSazonov Nov 14, 2018

Author Collaborator

They all relate to ISE. I think we can safely remove this.

This comment has been minimized.

Sign in to view
Copy link
@adityapatwardhan

adityapatwardhan Nov 14, 2018

Member

They were added when we had a full CLR build as well.
@adityapatwardhan

adityapatwardhan approved these changes Nov 14, 2018
View changes

@iSazonov iSazonov assigned TravisEz13 Nov 15, 2018

@iSazonov

This comment has been minimized.

Sign in to view
Copy link
Collaborator Author

commented Nov 15, 2018

@TravisEz13 Please update your review.

@iSazonov iSazonov added the CL-CodeCleanup label Nov 16, 2018

@TravisEz13

TravisEz13 approved these changes Nov 16, 2018
View changes

@TravisEz13 TravisEz13 merged commit 2c3e935 into PowerShell:master Nov 16, 2018
6 checks passed

6 checks passed

CodeFactor 3 issues fixed.
Details
PowerShell-CI-linux #PR-8190-20181113.01 succeeded
Details
PowerShell-CI-macos #PR-8190-20181113.01 succeeded
Details
PowerShell-CI-windows #PR-8190-20181113.01 succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
license/cla All CLA requirements met.
Details

@iSazonov iSazonov deleted the iSazonov:cleanup-assemblyinfo branch Nov 16, 2018

iSazonov added a commit to iSazonov/PowerShell that referenced this pull request Nov 29, 2018

@iSazonov
Cleanup assemblyinfo (PowerShell#8190) 
Remove old code from AssemblyInfo.cs
8bfe76d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.