Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign upFix tests running in Azure DevOps #8220
Conversation
PaulHigin
added some commits
Nov 1, 2018
PaulHigin
requested review from
TravisEz13 and
adityapatwardhan
Nov 9, 2018
PaulHigin
requested review from
anmenaga and
daxian-dbw
as
code owners
Nov 9, 2018
PaulHigin
assigned
TravisEz13
Nov 9, 2018
PaulHigin
removed the request for review
from
daxian-dbw
Nov 9, 2018
adityapatwardhan
requested changes
Nov 9, 2018
adityapatwardhan
approved these changes
Nov 9, 2018
adityapatwardhan
merged commit d4bf5c8
into
PowerShell:master
Nov 9, 2018
6 checks passed
CodeFactor
No issues found.
Details
PowerShell-CI-linux
#PR-8220-20181109.02 succeeded
Details
PowerShell-CI-macos
#PR-8220-20181109.02 succeeded
Details
PowerShell-CI-windows
#PR-8220-20181109.02 succeeded
Details
continuous-integration/appveyor/pr
AppVeyor build succeeded
Details
license/cla
All CLA requirements met.
Details
PaulHigin
deleted the
PaulHigin:RemoteTestExperiments
branch
Nov 12, 2018
TravisEz13
referenced this pull request
Nov 13, 2018
Closed
WIP: Add VSTS daily and feature tag support #7658
adityapatwardhan
referenced this pull request
Nov 14, 2018
Merged
Publish test package to AppVeyor daily build #8273
iSazonov
added
the
CL-Tools
label
Jan 17, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
PaulHigin commentedNov 9, 2018
PR Summary
This change fixes tests that were failing when run in Azure DevOps. Most issues were due to the tests running as non-elevated, and the solution was to add the "RequireAdminOnWindows" tag.
This is especially true for remoting tests, where I updated the HelpersRemoting module to create a new remote session, runspace, or invoke-command against a PSCore6 (rather than WindowsPowerShell) endpoint. If the endpoint doesn't exist then it is created. Creating endpoints and connecting to endpoints require elevated privileges, so I made all remoting tests use the "RequireAdminOnWindows" tag.
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:to the beginning of the title and remove the prefix when the PR is ready.[feature]if the change is significant or affects feature tests