★ wanayoo — archive 1999 https://github.com/PowerShell/PowerShell/pull/8220Nouvelle recherche | Portail wanayoo
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tests running in Azure DevOps #8220

Merged
merged 10 commits into from Nov 9, 2018

Conversation

Projects
None yet
4 participants
@PaulHigin
Copy link
Contributor

commented Nov 9, 2018

PR Summary

This change fixes tests that were failing when run in Azure DevOps. Most issues were due to the tests running as non-elevated, and the solution was to add the "RequireAdminOnWindows" tag.

This is especially true for remoting tests, where I updated the HelpersRemoting module to create a new remote session, runspace, or invoke-command against a PSCore6 (rather than WindowsPowerShell) endpoint. If the endpoint doesn't exist then it is created. Creating endpoints and connecting to endpoints require elevated privileges, so I made all remoting tests use the "RequireAdminOnWindows" tag.

PR Checklist

PaulHigin added some commits Nov 1, 2018

@PaulHigin PaulHigin requested review from TravisEz13 and adityapatwardhan Nov 9, 2018

@PaulHigin PaulHigin requested review from anmenaga and daxian-dbw as code owners Nov 9, 2018

@PaulHigin PaulHigin removed the request for review from daxian-dbw Nov 9, 2018

@adityapatwardhan adityapatwardhan merged commit d4bf5c8 into PowerShell:master Nov 9, 2018

6 checks passed

CodeFactor No issues found.
Details
PowerShell-CI-linux #PR-8220-20181109.02 succeeded
Details
PowerShell-CI-macos #PR-8220-20181109.02 succeeded
Details
PowerShell-CI-windows #PR-8220-20181109.02 succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
license/cla All CLA requirements met.
Details

@PaulHigin PaulHigin deleted the PaulHigin:RemoteTestExperiments branch Nov 12, 2018

@TravisEz13 TravisEz13 referenced this pull request Nov 13, 2018

Closed

WIP: Add VSTS daily and feature tag support #7658

7 of 11 tasks complete

@adityapatwardhan adityapatwardhan referenced this pull request Nov 14, 2018

Merged

Publish test package to AppVeyor daily build #8273

7 of 11 tasks complete

@iSazonov iSazonov added the CL-Tools label Jan 17, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.