Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign upUpdate SignType in signing.xml #8223
Conversation
TravisEz13
requested review from
adityapatwardhan,
anmenaga,
daxian-dbw and
PaulHigin
as
code owners
Nov 9, 2018
adityapatwardhan
approved these changes
Nov 12, 2018
adityapatwardhan
merged commit 655b8b6
into
PowerShell:master
Nov 12, 2018
7 checks passed
CodeFactor
No issues found.
Details
PowerShell-CI-linux
#PR-8223-20181109.01 succeeded
Details
PowerShell-CI-macos
#PR-8223-20181109.01 succeeded
Details
PowerShell-CI-spelling
#PR-8223-20181109.01 succeeded
Details
PowerShell-CI-windows
#PR-8223-20181109.01 succeeded
Details
continuous-integration/appveyor/pr
AppVeyor build succeeded
Details
license/cla
All CLA requirements met.
Details
TravisEz13
deleted the
TravisEz13:Update_Signing_xml
branch
Nov 13, 2018
iSazonov
assigned
adityapatwardhan
Jan 17, 2019
iSazonov
added
the
CL-BuildPackaging
label
Jan 17, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
TravisEz13 commentedNov 9, 2018
•
edited
PR Summary
Update SignType in signing.xml
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:to the beginning of the title and remove the prefix when the PR is ready.[feature]if the change is significant or affects feature tests