Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign upMake `install-powershell.sh` autodetect if it should use `wget` or `curl` #8225
+108
−18
Conversation
DarwinJS
requested review from
adityapatwardhan,
anmenaga,
daxian-dbw,
PaulHigin and
TravisEz13
as
code owners
Nov 10, 2018
iSazonov
assigned
TravisEz13
Nov 10, 2018
TravisEz13
changed the title
Install powershell adding curl wget autodetection detection issue #7872
Install powershell adding curl wget autodetection detection issue
Nov 13, 2018
TravisEz13
changed the title
Install powershell adding curl wget autodetection detection issue
Make `install-powershell.sh` autodetect if it should use `wget` or `curl`
Nov 13, 2018
This comment has been minimized.
This comment has been minimized.
|
I added a CI definition and filters to only run it if affected files are changed. I ran it here https://dev.azure.com/tplunk/powershell/_build/results?buildId=337&view=logs and it passed. @bmanikm Can you review? |
PaulHigin
reviewed
Nov 14, 2018
PaulHigin
approved these changes
Nov 14, 2018
DarwinJS
and others
added some commits
Sep 29, 2018
TravisEz13
force-pushed the
DarwinJS:install-powershell-add-curl-wget-detection-issue-7872
branch
from
87c00f2
to
9353138
Nov 14, 2018
This comment has been minimized.
This comment has been minimized.
|
rebased PR to hopefully fix unrelated test issues |
bmanikm
approved these changes
Nov 14, 2018
TravisEz13
merged commit a244c04
into
PowerShell:master
Nov 14, 2018
6 checks passed
CodeFactor
No issues found.
Details
PowerShell-CI-linux
#PR-8225-20181114.02 succeeded
Details
PowerShell-CI-macos
#PR-8225-20181114.02 succeeded
Details
PowerShell-CI-windows
#PR-8225-20181114.02 succeeded
Details
continuous-integration/appveyor/pr
AppVeyor build succeeded
Details
license/cla
All CLA requirements met.
Details
adityapatwardhan
added
the
CL-BuildPackaging
label
Nov 15, 2018
This comment has been minimized.
This comment has been minimized.
|
@TravisEz13 Reminder to add CL-XXX labels. |
DarwinJS
deleted the
DarwinJS:install-powershell-add-curl-wget-detection-issue-7872
branch
Nov 16, 2018
iSazonov
added a commit
to iSazonov/PowerShell
that referenced
this pull request
Nov 29, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
DarwinJS commentedNov 10, 2018
PR Summary
install-powershell.sh now autodetects whether curl or wget is installed to download secondary script when it is not found locally.
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:to the beginning of the title and remove the prefix when the PR is ready.[feature]if the change is significant or affects feature tests