Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign upRemove old 'customPSSnapInType' parameter from PSSnapInInfo() #8333
Conversation
iSazonov
self-assigned this
Nov 23, 2018
iSazonov
requested review from
TravisEz13,
SteveL-MSFT and
adityapatwardhan
Nov 23, 2018
iSazonov
changed the title
[Feature] Remove old 'customPSSnapInType' parameter from PSSnapInInfo()
Remove old 'customPSSnapInType' parameter from PSSnapInInfo()
Nov 23, 2018
daxian-dbw
approved these changes
Nov 26, 2018
|
Looks good. Please remove the unneeded resource string. |
| { | ||
| throw PSTraceSource.NewArgumentException( | ||
| "customPSSnapInType", | ||
| MshSnapInCmdletResources.CustomPSSnapInNotSupportedInPowerShellCore); |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
iSazonov
merged commit e2b5aac
into
PowerShell:master
Nov 26, 2018
6 checks passed
CodeFactor
45 issues fixed. 17 issues found.
Details
PowerShell-CI-linux
#PR-8333-20181126.01 succeeded
Details
PowerShell-CI-macos
#PR-8333-20181126.01 succeeded
Details
PowerShell-CI-windows
#PR-8333-20181126.01 succeeded
Details
continuous-integration/appveyor/pr
AppVeyor build succeeded
Details
license/cla
All CLA requirements met.
Details
iSazonov
deleted the
iSazonov:cleanup-pssnapininfo
branch
Nov 26, 2018
iSazonov
added
the
CL-CodeCleanup
label
Nov 26, 2018
iSazonov
added a commit
to iSazonov/PowerShell
that referenced
this pull request
Nov 29, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
iSazonov commentedNov 23, 2018
•
edited
PR Summary
Related #3565 and #4357.
CustomPSSnapIn is not supported in PowerShell Core and we can remove the old 'customPSSnapInType' parameter from internal API.
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:to the beginning of the title and remove the prefix when the PR is ready.[feature]if the change is significant or affects feature tests