Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign upFix `Get-Help` for advanced functions with MAML help content #8353
+20
−36
Conversation
adityapatwardhan
requested a review
from
TravisEz13
Nov 28, 2018
TravisEz13
approved these changes
Nov 28, 2018
adityapatwardhan
requested a review
from
Francisco-Gamino
as a
code owner
Nov 29, 2018
adityapatwardhan
changed the title
Update the static test content for PSReadline v2
Fix `Get-Help` for advanced functions with MAML help content
Nov 29, 2018
adityapatwardhan
added
the
CL-General
label
Nov 29, 2018
TravisEz13
approved these changes
Nov 30, 2018
adityapatwardhan
added some commits
Nov 28, 2018
adityapatwardhan
force-pushed the
adityapatwardhan:UpdateStaticHelpContent
branch
from
c272f3d
to
4d139c1
Nov 30, 2018
adityapatwardhan
merged commit 13e2559
into
PowerShell:master
Nov 30, 2018
6 checks passed
CodeFactor
2 issues fixed.
Details
PowerShell-CI-linux
#PR-8353-20181130.01 succeeded
Details
PowerShell-CI-macos
#PR-8353-20181130.01 succeeded
Details
PowerShell-CI-spelling
#PR-8353-20181130.02 succeeded
Details
PowerShell-CI-windows
#PR-8353-20181130.02 succeeded
Details
license/cla
All CLA requirements met.
Details
adityapatwardhan
deleted the
adityapatwardhan:UpdateStaticHelpContent
branch
Nov 30, 2018
TravisEz13
added a commit
that referenced
this pull request
Nov 30, 2018
iSazonov
assigned
adityapatwardhan
Dec 8, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
adityapatwardhan commentedNov 28, 2018
•
edited
PR Summary
If a module has advanced function and the help defined in MAML then the help file was not found under user scope.
This change updates the logic to look in a sub-folder for the module name under user scope help root.
Also enabled tests for
Microsoft.PowerShell.Archivemodule and removed tests for PSReadLine.PSReadLine tests were removed as the updatable help content does not have the latest help for v2.0.0
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:to the beginning of the title and remove the prefix when the PR is ready.[feature]if the change is significant or affects feature tests