★ wanayoo — archive 1999 https://github.com/PowerShell/PowerShell/pull/8353Nouvelle recherche | Portail wanayoo
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix `Get-Help` for advanced functions with MAML help content #8353

Merged

Conversation

Projects
None yet
2 participants
@adityapatwardhan
Copy link
Member

commented Nov 28, 2018 •

PR Summary

If a module has advanced function and the help defined in MAML then the help file was not found under user scope.
This change updates the logic to look in a sub-folder for the module name under user scope help root.

Also enabled tests for Microsoft.PowerShell.Archive module and removed tests for PSReadLine.

PSReadLine tests were removed as the updatable help content does not have the latest help for v2.0.0

PR Checklist

@adityapatwardhan adityapatwardhan requested a review from TravisEz13 Nov 28, 2018

@adityapatwardhan adityapatwardhan changed the title Update the static test content for PSReadline v2 Fix `Get-Help` for advanced functions with MAML help content Nov 29, 2018

adityapatwardhan added some commits Nov 28, 2018

Update the static test content for PSReadline v2
The name of the module and hence the help file name change in PSReadline version 2.
The cab and the zip files have the latest help content.
[Feature] Remove PSReadLine module from help tests
The updatable help content is not correct for PSReadLine module due to issue lzybkr/PSReadLine#819

Removed the module from help testing.

Also enabling tests for Microosoft.PowerShell.Archive covers the scenarios PSReadLine module was used for.

@adityapatwardhan adityapatwardhan force-pushed the adityapatwardhan:UpdateStaticHelpContent branch from c272f3d to 4d139c1 Nov 30, 2018

@adityapatwardhan adityapatwardhan merged commit 13e2559 into PowerShell:master Nov 30, 2018

6 checks passed

CodeFactor 2 issues fixed.
Details
PowerShell-CI-linux #PR-8353-20181130.01 succeeded
Details
PowerShell-CI-macos #PR-8353-20181130.01 succeeded
Details
PowerShell-CI-spelling #PR-8353-20181130.02 succeeded
Details
PowerShell-CI-windows #PR-8353-20181130.02 succeeded
Details
license/cla All CLA requirements met.
Details

@adityapatwardhan adityapatwardhan deleted the adityapatwardhan:UpdateStaticHelpContent branch Nov 30, 2018

TravisEz13 added a commit that referenced this pull request Nov 30, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.