Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign upUpdate help content for TabCompletion tests only if it does not exist #8355
Conversation
adityapatwardhan
requested a review
from
JamesWTruher
Nov 29, 2018
This comment has been minimized.
This comment has been minimized.
|
@JamesWTruher Pushed a change. Please have a look. |
JamesWTruher
approved these changes
Nov 30, 2018
|
lgtm |
adityapatwardhan
merged commit 8c3de33
into
PowerShell:master
Nov 30, 2018
6 checks passed
CodeFactor
No issues found.
Details
PowerShell-CI-linux
#PR-8355-20181129.02 succeeded
Details
PowerShell-CI-macos
#PR-8355-20181129.02 succeeded
Details
PowerShell-CI-spelling
#PR-8355-20181129.02 succeeded
Details
PowerShell-CI-windows
#PR-8355-20181129.02 succeeded
Details
license/cla
All CLA requirements met.
adityapatwardhan
deleted the
adityapatwardhan:FixTabCompletionHelpTest
branch
Nov 30, 2018
iSazonov
added
the
CL-Test
label
Nov 30, 2018
iSazonov
assigned
adityapatwardhan
Dec 8, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
adityapatwardhan commentedNov 29, 2018
•
edited
PR Summary
The TabCompletion tests need help content to be present. Currently we update the help in user scope if it does not exists. The help content could be in all users scope and would be found by tab completion.
The change also checks for help content in All Users scope.
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:to the beginning of the title and remove the prefix when the PR is ready.[feature]if the change is significant or affects feature tests