★ wanayoo — archive 1999 https://github.com/PowerShell/PowerShell/pull/8355Nouvelle recherche | Portail wanayoo
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update help content for TabCompletion tests only if it does not exist #8355

Merged

Conversation

Projects
None yet
4 participants
@adityapatwardhan
Copy link
Member

commented Nov 29, 2018 •

PR Summary

The TabCompletion tests need help content to be present. Currently we update the help in user scope if it does not exists. The help content could be in all users scope and would be found by tab completion.

The change also checks for help content in All Users scope.

PR Checklist

@adityapatwardhan adityapatwardhan requested a review from JamesWTruher Nov 29, 2018

@adityapatwardhan

This comment has been minimized.

Copy link
Member Author

commented Nov 29, 2018

@JamesWTruher Pushed a change. Please have a look.

@JamesWTruher
Copy link
Member

left a comment

lgtm

@adityapatwardhan adityapatwardhan merged commit 8c3de33 into PowerShell:master Nov 30, 2018

6 checks passed

CodeFactor No issues found.
Details
PowerShell-CI-linux #PR-8355-20181129.02 succeeded
Details
PowerShell-CI-macos #PR-8355-20181129.02 succeeded
Details
PowerShell-CI-spelling #PR-8355-20181129.02 succeeded
Details
PowerShell-CI-windows #PR-8355-20181129.02 succeeded
Details
license/cla All CLA requirements met.

@adityapatwardhan adityapatwardhan deleted the adityapatwardhan:FixTabCompletionHelpTest branch Nov 30, 2018

@iSazonov iSazonov added the CL-Test label Nov 30, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.