★ wanayoo — archive 1999 https://github.com/PowerShell/PowerShell/pull/8405Nouvelle recherche | Portail wanayoo
Skip to content

/PowerShell

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the name of the artifact to be unique per artifact #8405

Merged
merged 3 commits into from Dec 6, 2018

Conversation

Reviewers

@PaulHigin PaulHigin

@adityapatwardhan adityapatwardhan

@daxian-dbw daxian-dbw

@anmenaga anmenaga

Assignees

@adityapatwardhan adityapatwardhan

Labels
CL-BuildPackaging
Projects
None yet
Milestone
No milestone
3 participants
@TravisEz13 @adityapatwardhan @PaulHigin
@TravisEz13
Copy link
Member

commented Dec 5, 2018 •
edited

PR Summary

Update the name of the artifact to be unique per artifact

  • Also, remove an if condition specific to AppVeyor
  • Also, remove restriction on pushing artifacts to non-pull requests

Motivation: allow downloading individual artifacts

PR Checklist

TravisEz13 added some commits Dec 5, 2018

@TravisEz13
[Feature] Update the name of the artifact to be unique per artifact
Verified
This commit was signed with a verified signature.
@TravisEz13 TravisEz13 Travis Plunk
GPG key ID: B60A25843F0C2CD1 Learn about signing commits
2807094
@TravisEz13
[Feature] remove appveyor code
Verified
This commit was signed with a verified signature.
@TravisEz13 TravisEz13 Travis Plunk
GPG key ID: B60A25843F0C2CD1 Learn about signing commits
4b92693
@TravisEz13
[feature] remove block on pushing artifacts for pull requests
Verified
This commit was signed with a verified signature.
@TravisEz13 TravisEz13 Travis Plunk
GPG key ID: B60A25843F0C2CD1 Learn about signing commits
Loading status checks…
da7cc16

@TravisEz13 TravisEz13 requested review from adityapatwardhan, anmenaga, daxian-dbw and PaulHigin as code owners Dec 5, 2018

@adityapatwardhan

adityapatwardhan approved these changes Dec 6, 2018
View changes

@adityapatwardhan adityapatwardhan added the CL-BuildPackaging label Dec 6, 2018

@adityapatwardhan adityapatwardhan merged commit 50890b5 into PowerShell:master Dec 6, 2018
6 checks passed

6 checks passed

CodeFactor No issues found.
Details
PowerShell-CI-linux #PR-8405-20181205.01 succeeded
Details
PowerShell-CI-macos #PR-8405-20181205.01 succeeded
Details
PowerShell-CI-spelling #PR-8405-20181205.01 succeeded
Details
PowerShell-CI-windows #PR-8405-20181205.01 succeeded
Details
license/cla All CLA requirements met.
Details
@PaulHigin

PaulHigin reviewed Dec 6, 2018
View changes

tools/appveyor.psm1
@@ -517,16 +517,23 @@ function Push-Artifact
param(
[Parameter(Mandatory)]
[ValidateScript({Test-Path -Path $_})]
$Path
$Path,

This comment has been minimized.

Sign in to view
Copy link
@PaulHigin

PaulHigin Dec 6, 2018

Contributor

I think this would be more clear if $Path was named $ArtifactPath and $Name to $ArtifactName.
tools/appveyor.psm1
}
elseif ($env:TF_BUILD -and $env:BUILD_REASON -ne 'PullRequest') {

if ($env:TF_BUILD) {

This comment has been minimized.

Sign in to view
Copy link
@PaulHigin

PaulHigin Dec 6, 2018

Contributor

If $env:TF_BUILD is not defined then this cmdlet does nothing. Is that Ok, or should a warning be generated?

@TravisEz13 TravisEz13 deleted the TravisEz13:rename_artifacts branch Dec 6, 2018

@iSazonov iSazonov assigned adityapatwardhan Dec 8, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.