Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign upContributing guidelines: Remove references to Travis CI and AppVeyor #8617
Conversation
RDIL
requested review from
joeyaiello and
TravisEz13
as
code owners
Jan 9, 2019
This comment has been minimized.
This comment has been minimized.
|
Travis CI stopped being used maybe a couple months ago? It was used for MacOS and Linux agents before we switched to Azure. |
This comment has been minimized.
This comment has been minimized.
|
Haha it was a rhetorical question but okay, at least this PR removes it. |
iSazonov
assigned
TravisEz13
Jan 9, 2019
This comment has been minimized.
This comment has been minimized.
|
Not to be confused with @TravisEz13 @iSazonov |
RDIL
referenced this pull request
Jan 9, 2019
Merged
Remove all reference to AppVeyor and Travis CI from docs #8376
RDIL
changed the title
Contributing guidelines: Remove Travis CI
Contributing guidelines: Remove Travis CI and AppVeyor
Jan 9, 2019
adityapatwardhan
approved these changes
Jan 9, 2019
TravisEz13
approved these changes
Jan 9, 2019
TravisEz13
changed the title
Contributing guidelines: Remove Travis CI and AppVeyor
Contributing guidelines: Remove references Travis CI and AppVeyor
Jan 9, 2019
This comment has been minimized.
This comment has been minimized.
|
I edited your description to clarify this . #8617 (comment) We are supposed to give 24 hours for review. If I don't, merge this by EOD tomorrow, feel free to ping me. |
RDIL
changed the title
Contributing guidelines: Remove references Travis CI and AppVeyor
Contributing guidelines: Remove references to Travis CI and AppVeyor
Jan 9, 2019
This comment has been minimized.
This comment has been minimized.
|
|
This comment has been minimized.
This comment has been minimized.
|
@TravisEz13 its been about a day now. |
TravisEz13
merged commit a3d5578
into
PowerShell:master
Jan 10, 2019
6 checks passed
CodeFactor
No issues found.
Details
PowerShell-CI-linux
#PR-8617-20190109.02 succeeded
Details
PowerShell-CI-macos
#PR-8617-20190109.02 succeeded
Details
PowerShell-CI-static-analysis
#PR-8617-20190109.02 succeeded
Details
PowerShell-CI-windows
#PR-8617-20190109.02 succeeded
Details
license/cla
All CLA requirements met.
TravisEz13
added
the
CL-Docs
label
Jan 10, 2019
RDIL
deleted the
RDIL:patch-3
branch
Jan 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
RDIL commentedJan 9, 2019
•
edited by TravisEz13
PR Summary
Since when was Travis-CI used?? I removed it and replaced it with
Azure DevOpsbecause that isn't there.PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:to the beginning of the title and remove the prefix when the PR is ready.[feature]if the change is significant or affects feature tests