Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upGet tests working in PowerShell Core & and Non-Windows #648
Assignees
Labels
Comments
|
Marking Up-For-Grabs since I think it's relatively trivial, just a bit time consuming. |
|
I'll take a crack at this. |
|
@tylerl0706 Well, this may be an issue ... Looks like tests are targetting different .Net versions than the actual code. e.g. PowerShellEditorServices.Protocol is but the tests are This will not be an easy fix ... |
|
I could be wrong, but doesn't @rjmholt's netstandard migration PR do this already? |
|
Hrmm ok ... yup that looks right. This will probably be fixed in #741 Not really "Up For Grabs" anymore. |
|
Sorry @glennsarti, I've updated the issue |
|
This has been merged in #741 |
TylerLeonhardt
pushed a commit
to TylerLeonhardt/PowerShellEditorServices
that referenced
this issue
Feb 26, 2019
This change fixes an issue which causes and error to appear in the integrated console when debugging an untitled file without a launch.json configuration. The fix is to use the full Uri path when crafting a launch config for an untitled file. Resolves PowerShell#648.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Right now, we have a ton of stuff hardcoded for Windows PowerShell like:
PowerShellEditorServices/test/PowerShellEditorServices.Test.Host/ServerTestsBase.cs
Line 99 in 1e3234c
Our tests should support running on Windows PowerShell & PowerShell Core - and be able to run on any OS.