★ wanayoo — archive 1999 https://github.com/PowerShell/PowerShellEditorServices/pull/1022Nouvelle recherche | Portail wanayoo
Skip to content

/ PowerShellEditorServices

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Catch stream exceptions for some Debug Adapter stability. #1022

Merged
merged 2 commits into from Sep 16, 2019
Merged

Catch stream exceptions for some Debug Adapter stability. #1022

merged 2 commits into from Sep 16, 2019

Conversation

@TylerLeonhardt
Copy link
Member

@TylerLeonhardt TylerLeonhardt commented Sep 6, 2019

This helps protect from a crash we were seeing with the "Start without debugging" feature in VS Code.
@TylerLeonhardt
catch stream exceptions for Debug Adapter
Loading status checks…
17ca3a6
@TylerLeonhardt TylerLeonhardt changed the title Catch stream exceptions for some Debug Adapter stability Catch stream exceptions for some Debug Adapter stability. Sep 6, 2019
@SeeminglyScience
SeeminglyScience approved these changes Sep 9, 2019
View changes
Copy link
Collaborator

@SeeminglyScience SeeminglyScience left a comment

LGTM! One question
src/PowerShellEditorServices.Protocol/MessageProtocol/MessageWriter.cs Outdated
e is IOException)
{
// We catch this exception for when the DebugAdapter disconnects while still processing a message.
logger.WriteException("Tried to write to the output stream but it was already closed & broken.", e);

This comment has been minimized.

Sign in to view
@SeeminglyScience

SeeminglyScience Sep 9, 2019
Collaborator

This probably happens decently often, do we want to make this a verbose message? If you can't include an exception in the verbose message then never mind.

This comment has been minimized.

Sign in to view
@TylerLeonhardt

TylerLeonhardt Sep 10, 2019
Author Member

verbose doesn't allow an exception but I did change this to WriteHandledException!
@rjmholt
rjmholt approved these changes Sep 10, 2019
View changes
@TylerLeonhardt
Use WriteHandledException
Loading status checks…
adb25f5
@PowerShell PowerShell deleted a comment Sep 10, 2019
@rjmholt
rjmholt approved these changes Sep 15, 2019
View changes
@TylerLeonhardt TylerLeonhardt merged commit 95cb12e into PowerShell:master Sep 16, 2019
8 checks passed
8 checks passed
Codacy/PR Quality Review Up to standards. A positive pull request.
Details
PowerShellEditorServices-CI Build #PR-1022-20190910.01 had test failures
Details
PowerShellEditorServices-CI (PowerShell 5.1 | Windows 10) PowerShell 5.1 | Windows 10 succeeded
Details
PowerShellEditorServices-CI (PowerShell 6 | Ubuntu) PowerShell 6 | Ubuntu succeeded
Details
PowerShellEditorServices-CI (PowerShell 6 | Windows 10) PowerShell 6 | Windows 10 succeeded
Details
PowerShellEditorServices-CI (PowerShell 6 | macOS) PowerShell 6 | macOS succeeded
Details
PowerShellEditorServices-secret-scan #PR-1022-20190910.01 succeeded
Details
license/cla All CLA requirements met.
Details
@TylerLeonhardt TylerLeonhardt deleted the TylerLeonhardt:catch-stream-exceptions branch Sep 16, 2019
TylerLeonhardt added a commit to TylerLeonhardt/PowerShellEditorServices that referenced this pull request Sep 16, 2019
@TylerLeonhardt
Catch stream exceptions for some Debug Adapter stability. (PowerShell…
282235d 
…#1022)

* catch stream exceptions for Debug Adapter

* Use WriteHandledException
@TylerLeonhardt TylerLeonhardt mentioned this pull request Sep 16, 2019
Merged
TylerLeonhardt added a commit that referenced this pull request Sep 17, 2019
@TylerLeonhardt
Backport: Catch stream exceptions for some Debug Adapter stability. (#…
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
fbecd3f 
…1022) (#1026)

* catch stream exceptions for Debug Adapter

* Use WriteHandledException
@rjmholt rjmholt mentioned this pull request Oct 10, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rjmholt rjmholt

@SeeminglyScience SeeminglyScience

@rkeithhill rkeithhill

Assignees
No one assigned
Labels
Backport-Complete
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
@TylerLeonhardt @rjmholt @SeeminglyScience
You can’t perform that action at this time.