★ wanayoo — archive 1999 https://github.com/PowerShell/PowerShellEditorServices/pull/835Nouvelle recherche | Portail wanayoo
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Map new powershell.codeFormatting settings for new options in PSSA 1.18: WhitespaceInsideBrace and WhitespaceAroundPipe #835

Merged

Conversation

@bergmeister
Copy link
Collaborator

@bergmeister bergmeister commented Dec 20, 2018 •

This PR can only be merged once PSSA 1.18 has released

This wires up new PSSA settings from this PR with new vscode-powershell settings here

…WhitespaceAroundPipe to PSSA settings hash table
…orServices into PSSA_CheckInnerBraceAndPipe
@bergmeister
Copy link
Collaborator Author

@bergmeister bergmeister commented Mar 5, 2019

The depending PSSA PR has been merged now (meaning the feature will be in 1.18), so only the release is blocking the PR from merging, can you please start the review @TylerLeonhardt or @rjmholt in the meantime?

@rjmholt rjmholt changed the title [Do not merge yet] Map new powershell.codeFormatting settings for new options in PSSA 1.18: WhitespaceInsideBrace and WhitespaceAroundPipe Map new powershell.codeFormatting settings for new options in PSSA 1.18: WhitespaceInsideBrace and WhitespaceAroundPipe Mar 5, 2019
@rjmholt rjmholt requested review from rkeithhill and TylerLeonhardt Mar 5, 2019
@rjmholt
rjmholt approved these changes Mar 5, 2019
Copy link
Collaborator

@rkeithhill rkeithhill left a comment

LGTM. Thanks!

Copy link
Member

@TylerLeonhardt TylerLeonhardt left a comment

LGTM!

@TylerLeonhardt TylerLeonhardt merged commit 2316b35 into PowerShell:master Mar 20, 2019
4 checks passed
4 checks passed
Codacy/PR Quality Review Up to standards. A positive pull request.
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla All CLA requirements met.
bergmeister pushed a commit to bergmeister/PowerShellEditorServices that referenced this pull request Mar 20, 2019
TylerLeonhardt added a commit that referenced this pull request Mar 21, 2019
…WhitespaceAroundPipe to PSSA settings hash table (#835)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.