★ wanayoo — archive 1999 https://github.com/PowerShell/PowerShellEditorServices/pull/895Nouvelle recherche | Portail wanayoo
Skip to content

/ PowerShellEditorServices

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add warning to parameter validation set #895

Merged
merged 2 commits into from Mar 29, 2019
Merged

Add warning to parameter validation set #895

merged 2 commits into from Mar 29, 2019

Conversation

@Benny1007
Copy link
Contributor

@Benny1007 Benny1007 commented Mar 27, 2019

Add "Warning" to LogLevel parameter validation set of Start-EditorServices.ps1
@Benny1007
Add warning to parameter validation set
Loading status checks…
3a2d038
@Benny1007 Benny1007 requested a review from rjmholt as a code owner Mar 27, 2019
@Benny1007 Benny1007 mentioned this pull request Mar 27, 2019
Closed
@rkeithhill rkeithhill self-requested a review Mar 27, 2019
@rkeithhill
rkeithhill approved these changes Mar 27, 2019
View changes
Copy link
Collaborator

@rkeithhill rkeithhill left a comment

LGTM
@rkeithhill
rkeithhill reviewed Mar 27, 2019
View changes
module/PowerShellEditorServices/Start-EditorServices.ps1 Outdated Show resolved Hide resolved
@Benny1007
change order of validate set
Loading status checks…
2e104e8
@TylerLeonhardt
TylerLeonhardt approved these changes Mar 27, 2019
View changes
Copy link
Member

@TylerLeonhardt TylerLeonhardt left a comment

LGTM
@rjmholt
rjmholt approved these changes Mar 27, 2019
View changes
@TylerLeonhardt TylerLeonhardt merged commit dd73ecc into PowerShell:master Mar 29, 2019
3 checks passed
3 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla All CLA requirements met.
TylerLeonhardt added a commit that referenced this pull request Mar 29, 2019
@Benny1007 @TylerLeonhardt
Add warning to parameter validation set (#895)
Loading status checks…
d8cf59c 
* Add warning to parameter validation set

* change order of validate set
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rkeithhill rkeithhill

@TylerLeonhardt TylerLeonhardt

@rjmholt rjmholt

Assignees
No one assigned
Labels
Backport-Complete
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
@Benny1007 @TylerLeonhardt @rkeithhill @rjmholt
You can’t perform that action at this time.