★ wanayoo — archive 1999 https://github.com/PowerShell/PowerShellGet/pull/273Nouvelle recherche | Portail wanayoo
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor build to use PSPackageProject #273

Merged

Conversation

@PaulHigin
Copy link
Collaborator

@PaulHigin PaulHigin commented Oct 1, 2020

This is the first build refactoring that arranges PowerShellGet to use PSPackageProject module for build/test/compliance/signing/publishing.

  • Files have been moved to their needed locations

  • The build script has been refactored to conform to PSPackageProject

  • CI yml files have been added but not fully changed for PowerShellGet and not yet tested

  • Cmldet help files have been moved to location that conforms with PSPackageProject

@PaulHigin PaulHigin requested review from alerickson, anamnavi and SteveL-MSFT Oct 1, 2020
@alerickson
Copy link
Member

@alerickson alerickson commented Oct 5, 2020

There's already a build file in src, can we merge the two files (either getting rid of that build file or the one in this repo)?

@alerickson
Copy link
Member

@alerickson alerickson commented Oct 5, 2020

@sdwheeler had opened a PR adding all the documentation files into 'docs'. Do these files explicitly need to be in a folder called 'docs' or is moving them to 'help' okay?

@alerickson
Copy link
Member

@alerickson alerickson commented Oct 5, 2020

There's already a build file in src, can we merge the two files (either getting rid of that build file or the one in this repo)?

Nevermind, just saw that you removed the other build script

pr:
branches:
include:
- master

This comment has been minimized.

@alerickson

alerickson Oct 5, 2020
Member

Is this setting up CI explicitly for the master branch? If so can we change this to development?

This comment has been minimized.

@PaulHigin

PaulHigin Oct 5, 2020
Author Collaborator

CI is not running yet, but when it does it will run on any selected branch. I am still working to get a project set up.

@PaulHigin
Copy link
Collaborator Author

@PaulHigin PaulHigin commented Oct 5, 2020

I updated the tests to work with Pester 4.x. I think we should standardize on this version as the rest of PowerShell/Module tests already do. There are a number of breaking changes in 5.x that make CI difficult.

Also I temporarily disabled the older tests since they are not running successfully and also change machine state. I think they need to be reviewed.

@anamnavi
Copy link
Collaborator

@anamnavi anamnavi commented Oct 5, 2020

messed Paul about the one question I had and got a better understanding. The rest of the PR looks good to me :)

```

**Note**

This comment has been minimized.

@alerickson

alerickson Oct 5, 2020
Member

Thanks for adding this!

@alerickson alerickson merged commit f1ddcb3 into PowerShell:development Oct 5, 2020
1 of 2 checks passed
1 of 2 checks passed
Codacy/PR Quality Review Not up to standards. This pull request quality could be better.
Details
license/cla All CLA requirements met.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.