★ wanayoo — archive 1999 https://github.com/activeadmin/activeadmin/pull/5946Nouvelle recherche | Portail wanayoo
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make suppression confirm message gender-neutral #5946

Merged
merged 2 commits into from Nov 28, 2019

Conversation

@cprodhomme
Copy link
Contributor

cprodhomme commented Nov 26, 2019 •

change traductions 🇫🇷 🇪🇸

@leio10
Copy link
Contributor

leio10 commented Nov 26, 2019 •

Hi @cprodhomme, nice improvement! If you search for delete_confirmation in that file, you will find that there are two more appearances of that message, maybe we should change all of them. 😬

Also, if you wish, you can add similar changes for the spanish translations (es.yml) to this PR:

line 26: delete_confirmation: "¿Confirma que desea borrar este elemento?"
line 92: delete_confirmation: "Se eliminarán %{plural_model}. ¿Desea continuar?"
line 108: delete_confirmation: "¿Confirma que desea borrar este comentario?"
@cprodhomme
Copy link
Contributor Author

cprodhomme commented Nov 27, 2019 •

Hi @cprodhomme, nice improvement! If you search for delete_confirmation in that file, you will find that there are two more appearances of that message, maybe we should change all of them. 😬

Also, if you wish, you can add similar changes for the spanish translations (es.yml) to this PR:

line 26: delete_confirmation: "¿Confirma que desea borrar este elemento?"
line 92: delete_confirmation: "Se eliminarán %{plural_model}. ¿Desea continuar?"
line 108: delete_confirmation: "¿Confirma que desea borrar este comentario?"

i have made these changes ! 😃

@deivid-rodriguez deivid-rodriguez changed the title make suppression confirm message gender-neutral Make suppression confirm message gender-neutral Nov 28, 2019
Copy link
Member

deivid-rodriguez left a comment

😍

Copy link
Member

javierjulio left a comment

Thank you! ❤️

@javierjulio javierjulio merged commit dd0a16f into activeadmin:master Nov 28, 2019
17 checks passed
17 checks passed
ci/circleci: jruby92rails52 Your tests passed on CircleCI!
Details
ci/circleci: jruby92rails60 Your tests passed on CircleCI!
Details
ci/circleci: lint_and_docs Your tests passed on CircleCI!
Details
ci/circleci: ruby24rails52 Your tests passed on CircleCI!
Details
ci/circleci: ruby25rails52 Your tests passed on CircleCI!
Details
ci/circleci: ruby25rails60 Your tests passed on CircleCI!
Details
ci/circleci: ruby26rails52 Your tests passed on CircleCI!
Details
ci/circleci: ruby26rails60 Your tests passed on CircleCI!
Details
ci/circleci: ruby26rails60turbolinks Your tests passed on CircleCI!
Details
ci/circleci: setup_coverage Your tests passed on CircleCI!
Details
ci/circleci: testapp52 Your tests passed on CircleCI!
Details
ci/circleci: testapp60 Your tests passed on CircleCI!
Details
ci/circleci: testapp60turbolinks Your tests passed on CircleCI!
Details
ci/circleci: upload_coverage Your tests passed on CircleCI!
Details
codeclimate All good!
Details
codeclimate/diff-coverage 100% (70% threshold)
Details
codeclimate/total-coverage 99% (0.0% change)
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.