Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upGitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
Complete quoting for parameters of some CMake commands #182
Comments
|
Thanks for link and suggestion. I'll put it to the todo list. |
|
It seems that there a few more update candidates left over. |
|
Since you have already a good overview + fix suggestions, mind making a pull request for it? |
|
I assume that @Hamdor would like to try a bit more clean-up of the affected build scripts. |
|
Feel free to create a pull request |
|
Do any of the affected build scripts belong to external software projects? |
|
It's all CAF and its submodules. |
|
I'll close this since there wasn't any activity on this recently. |
Some parameters (like "${DOXYGEN_EXECUTABLE}" and "${CMAKE_CURRENT_SOURCE_DIR}") are passed to CMake commands in your build scripts without enclosing them by quotation marks. I see that these places will result in build difficulties if the contents of the used variables will contain special characters like semicolons.
I would recommend to apply advices from a wiki article.