Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upGitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
refactor response create function outside of promise handler #132
Conversation
|
This will depend on the size impact - I've updated the repo to include a size check, we'll see what it nets. |
|
Ah - it looks like this adds a named export to the actual unfetch package, which means it won't work - folks using CommonJS will have to do Instead, if we could retrofit your work here into proper support for the Response interface, that would definitely be a justifiable export! It would be a nice step towards supporting |
|
|
@kalisjoshua that'll be the added export. One quick solution to check this would be to move the |
not sure that this is favorable or not but thought that it might be and it allows for easier testing of the creation of responses and their properties.
1477655
to
ac63b91
|
This is done now.
I will look into the Response interface compatibility. |
|
|
Interesting that the numbers are still so increased. My guess is that's because we're ending up with a closure around the two top-level functions, whereas currently there is no closure required since all functionality exists within the single |
|
It's interesting to look at the compiled output diff of |
|
I think the biggest contributor to the bloat that I created is because of the lifting of the |
673f183
to
3986993
|
not sure that this is favorable or not but thought that it might be and it allows
for easier testing of the creation of responses and their properties.