★ wanayoo — archive 1999 https://github.com/elixirschool/elixirschool/pull/1438Nouvelle recherche | Portail wanayoo
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[KO] Bump up specifics/ecto to 1.2.0 #1438

Merged
merged 3 commits into from May 10, 2018

Conversation

@ghost
Copy link

@ghost ghost commented May 8, 2018

No description provided.

Yeongju Kang added 2 commits May 8, 2018
Yeongju Kang
Yeongju Kang
@doomspork doomspork requested review from marocchino and elixirschool/korean May 8, 2018
Copy link
Contributor

@yosangwon yosangwon left a comment

Thanks for your work! I have small suggestions.

@@ -9,6 +11,13 @@ Ecto는 공식적인 Elixir 프로젝트로 데이터베이스를 감싸는 부

## 설정하기

슈퍼바이저 트리를 포함한 프로젝트 생성:

This comment has been minimized.

@yosangwon

yosangwon May 9, 2018
Contributor

Can you make these sentenses to be more finished-looking? like

슈퍼바이저 트리를 포함해서 새 애플리케이션을 생성합니다.

This comment has been minimized.

@ghost

ghost May 9, 2018
Author

Thank you for the guide! I updated all following your guide including the below job.

@@ -17,12 +26,10 @@ defp deps do
end
```

이제 Ecto와 어댑터를 application의 목록에 추가할 수 있습니다.
아래 명령어를 통해 의존성 있는 라이브러리를 가져옵니다:

This comment has been minimized.

@yosangwon

yosangwon May 9, 2018
Contributor

We don't usually use colons in native Korean writings, how about changing to periods?

Yeongju Kang
@marocchino marocchino merged commit 737895b into elixirschool:master May 10, 2018
@marocchino
Copy link
Contributor

@marocchino marocchino commented May 10, 2018

@budongxin Thanks! 😍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.