★ wanayoo — archive 1999 https://github.com/feathersjs/feathers/issues/111Nouvelle recherche | Portail wanayoo
Skip to content

/ feathers

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Custom service events #111

Closed
daffl opened this issue Feb 12, 2015 · 4 comments
Closed

Custom service events #111

daffl opened this issue Feb 12, 2015 · 4 comments
Assignees
@daffl
Labels
Feature
Milestone
1.1.0

Comments

@daffl
Copy link
Member

@daffl daffl commented Feb 12, 2015

As discussed in #108 it would be nice to allow custom events on services. As an example, a payment service might want to notify the user about the process during payments by emitting log events:

var paymentService = {
  events: [ 'log' ],

  create(data, params) {
    var log = message => this.emit('log', { message: message, user: params.user });
    var errorHandler = error => log(`There was an error processing your payment: ${error.message}`);

    return addCreditCard(data.cc).then(cc => {
      log(`Credit card ${cc.displayName} added successfully`);

      return processPayment(data).then(paymentInfo => {
        log(`Payment of ${paymentInfo.amount}.- successful!`);

        return paymentInfo
      });
    }).fail(errorHandler);
  }
};

app.use('/payments', paymentService);

And on the client we could do:

socket.on('payments log', function(data) {
  $('#payment .logs').append(`<li>${data.message}</li>`);
});

And also generalize event filtering which helps decide to decide what events to dispatch where:

let paymentService = app.service('payments');

paymentService.filter('updated', function(data, params, callback) {
  if(data.company_id !== params.user.company_id) {
    return callback(null, false);
  }

  return callback(null, data);
});

paymentService.filter('log', function(data, params, callback) {
  if(data.user.id !== params.user.id) {
    return callback(null, false);
  }

  return callback(null, data.message);
});
@daffl daffl self-assigned this Feb 12, 2015
@daffl daffl added this to the 1.1.0 milestone Feb 12, 2015
@daffl
Copy link
Member Author

@daffl daffl commented Feb 12, 2015

The default behaviour for updated, patched, created and removed events is currently to dispatch them to every connected client. You probably do not want that in any application which currently means you have to always add a filter. It would probably also make sense to have a filter that is applied to everything by default (which e.g. checks if the connected user is the same as the user set in the data).

The default for events should be to not dispatch at all until you add a filter. Unfortunately that would be a breaking change and could only be introduced in version 2.
@daffl daffl added the Feature label Feb 12, 2015
@marshallswain
Copy link
Member

@marshallswain marshallswain commented Feb 13, 2015

Maybe the current default behavior for events could be moved into a plugin? Maybe a dedicated page for creating plugin would be a good thing for the new site. I need to re-read the entire site. It seems like quite a bit has been added since my last read.
@daffl
Copy link
Member Author

@daffl daffl commented Feb 13, 2015

Actually I think for Feathers 2, the providers (feathers.rest, feathers.socketio, feathers.primus maybe feathers.zerorpc) should be moved into their own plugins. Then yes, adding event handling separately would make sense (e.g. those plugins would depend on feathers-events or the core would depend on some kind of events plugin).

For 1.1 we'll have to add this into the core and also keep backwards compatibility with the updated(data, params, callback) etc. methods.
@daffl daffl mentioned this issue Feb 27, 2015
Closed
@daffl daffl mentioned this issue Mar 11, 2015
Merged
@daffl daffl closed this in #128 Apr 10, 2015
@daffl daffl mentioned this issue Jan 12, 2016
Closed
daffl added a commit that referenced this issue Aug 21, 2018
@greenkeeper @daffl
chore(package): update sinon to version 5.0.0 (#111)
7919c88
daffl added a commit that referenced this issue Aug 21, 2018
@greenkeeper @daffl
chore(package): update sinon to version 5.0.0 (#111)
453bf12
daffl added a commit that referenced this issue Aug 21, 2018
@greenkeeper @daffl
Update @feathersjs/transport-commons to the latest version 🚀 (#111)
58a3565 
* fix(package): update @feathersjs/transport-commons to version 4.0.0

* Update tests to take connection into consideration
daffl added a commit that referenced this issue Aug 22, 2018
@greenkeeper @daffl
Update @feathersjs/transport-commons to the latest version 🚀 (#111)
676ae63 
* fix(package): update @feathersjs/transport-commons to version 4.0.0

* Update tests to take connection into consideration
daffl added a commit that referenced this issue Aug 25, 2018
@daffl
Merge pull request #111 from feathersjs/ast-find-next
2e2a4cf 
Fix AST transformation when there is another expression
@lock
Copy link

@lock lock bot commented Feb 8, 2019

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue with a link to this issue for related bugs.
@lock lock bot locked as resolved and limited conversation to collaborators Feb 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@daffl daffl

Labels
Feature
Projects
None yet
Milestone
1.1.0
Linked pull requests

Successfully merging a pull request may close this issue.

Allow services to dispatch custom events.
2 participants
@marshallswain @daffl
You can’t perform that action at this time.