★ wanayoo — archive 1999 https://github.com/feathersjs/feathers/pull/110Nouvelle recherche | Portail wanayoo
Skip to content

/ feathers

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sure .setup() runs on dynamic services. #110

Merged
merged 1 commit into from Feb 13, 2015
Merged

Make sure .setup() runs on dynamic services. #110

merged 1 commit into from Feb 13, 2015

Conversation

@marshallswain
Copy link
Member

@marshallswain marshallswain commented Feb 12, 2015

Setup() wasn't being run on dynamic services. I've included a fix and updated one of the tests to make sure setup runs.

Oh, I also moved stripSlashes(location) to the top of app.service() and replaced all duplicate instances of it with location.
@marshallswain
Copy link
Member Author

@marshallswain marshallswain commented Feb 13, 2015

@daffl Does this look ready to merge?
test/providers/primus.test.js Outdated
socket.on('tasks removed', function (data) {
service.removed = oldRemoved;
assert.equal(data.id, 23);
done();
console.log('Ready: ' + ready);

This comment has been minimized.

Sign in to view
@daffl

daffl Feb 13, 2015
Member

console.log
@daffl
Copy link
Member

@daffl daffl commented Feb 13, 2015

Yes, after you remove the console.log and please squash the commits into one (http://gitready.com/advanced/2009/02/10/squashing-commits-with-rebase.html - but I can to that, too before merging).
@marshallswain
Fixes setup() for Dynamic Services.
Loading status checks…
78dbec3
@marshallswain marshallswain force-pushed the fix-setup branch from dbce3b6 to 78dbec3 Feb 13, 2015
@marshallswain
Copy link
Member Author

@marshallswain marshallswain commented Feb 13, 2015

Wow. squash is new for me. That was a beautiful experience.
marshallswain added a commit that referenced this pull request Feb 13, 2015
@marshallswain
Merge pull request #110 from feathersjs/fix-setup
Loading status checks…
efeab46 
Make sure .setup() runs on dynamic services.
@marshallswain marshallswain merged commit efeab46 into master Feb 13, 2015
1 check passed
1 check passed
continuous-integration/travis-ci The Travis CI build passed
Details
@marshallswain marshallswain deleted the fix-setup branch Feb 13, 2015
@marshallswain marshallswain mentioned this pull request Feb 17, 2015
Merged
daffl added a commit that referenced this pull request Aug 21, 2018
@daffl
Change dependency to @feathersjs/transport-commons (#110)
1b48aba
daffl added a commit that referenced this pull request Aug 22, 2018
@daffl
Change dependency to @feathersjs/transport-commons (#110)
85d482a
daffl added a commit that referenced this pull request Aug 24, 2018
@greenkeeper @daffl
fix(package): update generator-feathers to version 1.2.9 (#110)
17e55dc
daffl added a commit that referenced this pull request Aug 25, 2018
@daffl
Merge pull request #110 from feathersjs/fix-test
e37f33f 
Fix generated app tests for latest packages
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@marshallswain @daffl
You can’t perform that action at this time.