★ wanayoo — archive 1999 https://github.com/hetznercloud/cli/pull/71

Nouvelle recherche | Portail wanayoo

hetznercloud / cli

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set cli version on compile #71

Merged

thcyron merged 4 commits into master from set-version-on-compile

Jan 17, 2018

Contributor

thetechnick commented Jan 17, 2018

Build release using:

./script/build.bash linux amd64 `./script/git-version.bash`

thetechnick requested a review from thcyron


          Set cli version on compile

8a47ee8

thetechnick force-pushed the set-version-on-compile branch from f95eb98 to 8a47ee8

Nico Schieder added 2 commits


          Change bats version testcase

af811a5


          Provide compiler flags for test build

d1e4c5e

thcyron requested changes

Member

thcyron left a comment

Indentation is inconsistent in script/git-version.bash.

version.go Outdated

  
      @@ -6,7 +6,8 @@ import (
    
        	"github.com/spf13/cobra"

        )

        const Version = "1.0.0"

        // Version is set via compiler flags (see script/build.bash)

        var Version = "was not build properly"

thcyron Jan 17, 2018
Member

built


          Fix git-version.bash intentation and fix typo in version

0c2b6b8

thcyron merged commit a1b0a3a into master

2 checks passed

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed

Details

continuous-integration/travis-ci/push The Travis CI build passed

Details

thcyron deleted the set-version-on-compile branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

You can’t perform that action at this time.