★ wanayoo — archive 1999 https://github.com/hetznercloud/hcloud-python/pull/3Nouvelle recherche | Portail wanayoo
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepeare Documentation for Release #3

Merged
merged 28 commits into from Feb 20, 2019
Merged

Prepeare Documentation for Release #3

merged 28 commits into from Feb 20, 2019

Conversation

@LKaemmerling
Copy link
Member

@LKaemmerling LKaemmerling commented Dec 28, 2018

We need to prepare the documentation for the release.

This PR polish the readme of the repo and the documentation on read the docs (rtd).

First of all we should specify the scope of the readme as "for hcloud-python developers".

The docs on rtd is for users of the hcloud-python module, so we should start with some easy examples and a basic introduction. Then we should list all steps needed for the installation.

I also removed the authors.md, because we didn't have it elsewhere in our repositories.

This is just a first draft of how we could polish the documentation. What do you think about this?

@LKaemmerling LKaemmerling requested a review from LD250 Dec 28, 2018
@LKaemmerling
Copy link
Member Author

@LKaemmerling LKaemmerling commented Dec 28, 2018

You can see the generated documentation on:
https://hcloud-python.readthedocs.io/en/documentation/

Copy link
Member

@LD250 LD250 left a comment

  1. At the moment, we have only two *.md files: CHANGELOG.md and CONTRIBUTING.md. Everything else is *.rst. Should we move completely to *.rst?

  2. Is usage.rst up to date?

  3. Autogenerated package documentation looks a bit messy. We should think about better structure. One option is to create this structure manually, (Example: https://github.com/requests/requests/blob/master/docs/api.rst)

  4. We can use this link as a guide for the next steps
    https://realpython.com/documenting-python-code/

@LKaemmerling LKaemmerling force-pushed the documentation branch from e45bce7 to d70bdd4 Feb 5, 2019
@LKaemmerling LKaemmerling added this to In progress in v1.0.0 Feb 7, 2019
@LKaemmerling
Copy link
Member Author

@LKaemmerling LKaemmerling commented Feb 7, 2019

@LD250 i think we are ready here. Can you have a look over it?
@thcyron can you have a look too? What do you think about the proposal? https://hcloud-python.readthedocs.io/en/documentation/

@LD250
Copy link
Member

@LD250 LD250 commented Feb 12, 2019

I like the table of content and I think docs look good for launch. Please merge this one.

I think we should consider moving to the docstrings at some point. In this way, documentation will be more maintainable and will be available on only on readthedocs but in the code base as well.

I believe #13 will be the next step in documentation improvement.

docs/domain/global.rst Outdated Show resolved Hide resolved
@thcyron
Copy link
Member

@thcyron thcyron commented Feb 12, 2019

For me, #13 is a requirement for a version 1.0 release. People will look at our code and a total lack of in-code documentation won’t give them the feeling that our library is mature and high-quality.

@LKaemmerling LKaemmerling force-pushed the documentation branch from fd88c0b to 58e3c05 Feb 15, 2019
hcloud/actions/client.py Outdated Show resolved Hide resolved
hcloud/actions/client.py Outdated Show resolved Hide resolved
hcloud/actions/client.py Outdated Show resolved Hide resolved
hcloud/actions/client.py Outdated Show resolved Hide resolved
docs/domain/global.rst Outdated Show resolved Hide resolved
hcloud/core/client.py Outdated Show resolved Hide resolved
hcloud/datacenters/client.py Outdated Show resolved Hide resolved
hcloud/images/client.py Outdated Show resolved Hide resolved
hcloud/images/client.py Show resolved Hide resolved
hcloud/ssh_keys/client.py Outdated Show resolved Hide resolved
v1.0.0 automation moved this from In progress to Needs review Feb 18, 2019
hcloud/ssh_keys/client.py Outdated Show resolved Hide resolved
@LKaemmerling LKaemmerling force-pushed the documentation branch from 4316042 to fb8c2d5 Feb 20, 2019
Makefile Outdated Show resolved Hide resolved
hcloud/actions/client.py Outdated Show resolved Hide resolved
hcloud/actions/client.py Outdated Show resolved Hide resolved
hcloud/images/client.py Outdated Show resolved Hide resolved
hcloud/images/client.py Outdated Show resolved Hide resolved
docs/usage/actions/actions.rst Outdated Show resolved Hide resolved
LKaemmerling added 13 commits Dec 28, 2018
WIP
WIP
WIP
WIP
Fix Travis CI
Add SSH Key Docs
Add Images
Add Volumes
Use `False` instead of false
Use `True` instead of true
Remove Description from functions that are correctly named like "Deletes a server", there is no need for an additional description
WIP
LKaemmerling added 14 commits Feb 15, 2019
Fix tests
Add server types, locations, datacenters and floating ips
Make _add_meta_to_result protected
Co-Authored-By: LKaemmerling <4281581+LKaemmerling@users.noreply.github.com>
Rename APIException Reference
Co-Authored-By: LKaemmerling <4281581+LKaemmerling@users.noreply.github.com>
Fix tests
@LKaemmerling LKaemmerling force-pushed the documentation branch from a6e313c to 5e1419b Feb 20, 2019
@LD250
LD250 approved these changes Feb 20, 2019
v1.0.0 automation moved this from Needs review to Reviewer approved Feb 20, 2019
@LKaemmerling LKaemmerling merged commit 5c82152 into master Feb 20, 2019
2 checks passed
2 checks passed
Travis CI - Branch Build Passed
Details
Travis CI - Pull Request Build Passed
Details
v1.0.0 automation moved this from Reviewer approved to Done Feb 20, 2019
@LKaemmerling LKaemmerling deleted the documentation branch Feb 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
v1.0.0
  
Done
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.