★ wanayoo — archive 1999 https://github.com/joyent/node/pull/6648Nouvelle recherche | Portail wanayoo
Skip to content
Sign up
This repository

/node

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP
New issue

benchmark: fixate `ciphers in tls benchmarks #6648

Closed
wants to merge 1 commit into from
+4 −2

Labels

master pr

Milestone

No milestone

Assignee

No one assigned

2 participants

Fedor Indutny Trevor Norris
Fedor Indutny
Collaborator
indutny commented

Benchmark should always use the same cipher in order to be truthful.

Fedor Indutny indutny benchmark: fixate `ciphers in tls benchmarks … 
Benchmark should always use the same cipher in order to be truthful.
 b83d2d3
Fedor Indutny
Collaborator
indutny commented

Btw, that's how we are comparing to the 0.10:

tls/throughput.js dur=5 type=buf size=2: ./node: 2.6365 /Users/indutny/.node/0.10.22/bin/node: 0.56838 ...... 363.86%
tls/throughput.js dur=5 type=buf size=1024: ./node: 646.54 /Users/indutny/.node/0.10.22/bin/node: 174 ....... 271.57%
tls/throughput.js dur=5 type=buf size=1048576: ./node: 967.05 /Users/indutny/.node/0.10.22/bin/node: 319.26 . 202.90%
tls/throughput.js dur=5 type=asc size=2: ./node: 2.2159 /Users/indutny/.node/0.10.22/bin/node: 0.49407 ...... 348.50%
tls/throughput.js dur=5 type=asc size=1024: ./node: 603.59 /Users/indutny/.node/0.10.22/bin/node: 153.03 .... 294.42%
tls/throughput.js dur=5 type=asc size=1048576: ./node: 913.75 /Users/indutny/.node/0.10.22/bin/node: 308.25 . 196.43%
tls/throughput.js dur=5 type=utf size=2: ./node: 2.2061 /Users/indutny/.node/0.10.22/bin/node: 0.4911 ....... 349.21%
tls/throughput.js dur=5 type=utf size=1024: ./node: 610.3 /Users/indutny/.node/0.10.22/bin/node: 144.96 ..... 321.02%
tls/throughput.js dur=5 type=utf size=1048576: ./node: 771.83 /Users/indutny/.node/0.10.22/bin/node: 274.65 . 181.02%
tls/tls-connect.js concurrency=1 dur=5: ./node: 589.12 /Users/indutny/.node/0.10.22/bin/node: 328.99 ......... 79.07%
tls/tls-connect.js concurrency=10 dur=5: ./node: 666.4 /Users/indutny/.node/0.10.22/bin/node: 352.97 ......... 88.80%
Trevor Norris
Collaborator
trevnorris commented

Awesome. LGTM.

Should the word "ciphers" be prepended with a backtick?

Fedor Indutny
Collaborator
indutny commented

Yeah, that's a typo.

Fedor Indutny
Collaborator
indutny commented

Thanks, landed in f5ab3e4

Fedor Indutny indutny deleted the branch
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Dec 06, 2013
  1. Fedor Indutny

    benchmark: fixate `ciphers in tls benchmarks …

    indutny authored 
    Benchmark should always use the same cipher in order to be truthful.
    b83d2d3
This page is out of date. Refresh to see the latest.
Unified Split
Showing with 4 additions and 2 deletions.
  1. +2 −1  benchmark/tls/throughput.js
  2. +2 −1  benchmark/tls/tls-connect.js
3  benchmark/tls/throughput.js
View
@@ -39,7 +39,8 @@ function main(conf) {
options = { key: fs.readFileSync(cert_dir + '/test_key.pem'),
cert: fs.readFileSync(cert_dir + '/test_cert.pem'),
- ca: [ fs.readFileSync(cert_dir + '/test_ca.pem') ] };
+ ca: [ fs.readFileSync(cert_dir + '/test_ca.pem') ],
+ ciphers: 'AES256-GCM-SHA384' };
server = tls.createServer(options, onConnection);
setTimeout(done, dur * 1000);
3  benchmark/tls/tls-connect.js
View
@@ -23,7 +23,8 @@ function main(conf) {
var cert_dir = path.resolve(__dirname, '../../test/fixtures'),
options = { key: fs.readFileSync(cert_dir + '/test_key.pem'),
cert: fs.readFileSync(cert_dir + '/test_cert.pem'),
- ca: [ fs.readFileSync(cert_dir + '/test_ca.pem') ] };
+ ca: [ fs.readFileSync(cert_dir + '/test_ca.pem') ],
+ ciphers: 'AES256-GCM-SHA384' };
server = tls.createServer(options, onConnection);
server.listen(common.PORT, onListening);
Something went wrong with that request. Please try again.