Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upGitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
Provide launchInTerminal feature to support console input #122
Conversation
Signed-off-by: Jinbo Wang <jinbwan@microsoft.com>
...soft.java.debug.core/src/main/java/com/microsoft/java/debug/core/adapter/ProtocolServer.java
Outdated
| } else if (ex != null) { | ||
| logger.log(Level.SEVERE, String.format("DebugSession dispatch exception: %s", ex.toString()), ex); | ||
| } else { | ||
| logger.log(Level.SEVERE, "The request dispatcher should not return null response."); |
akaroml
Nov 29, 2017
Member
Please just throw an exception with some message and the exceptionally will catch that.
Please just throw an exception with some message and the exceptionally will catch that.
...soft.java.debug.core/src/main/java/com/microsoft/java/debug/core/adapter/ProtocolServer.java
Outdated
| sendResponse(response); | ||
| } else if (ex instanceof DebugException) { | ||
| sendResponse(AdapterUtils.setErrorResponse(response, | ||
| ErrorCode.parse(((DebugException) ex).getErrorCode()), |
akaroml
Nov 29, 2017
Member
Too much indention.
Too much indention.
...soft.java.debug.core/src/main/java/com/microsoft/java/debug/core/adapter/ProtocolServer.java
Outdated
| ex.getMessage() != null ? ex.getMessage() : ex.toString())); | ||
| } else { | ||
| logger.log(Level.SEVERE, "The request dispatcher should not return null response."); | ||
| sendResponse(AdapterUtils.setErrorResponse(response, | ||
| ErrorCode.UNKNOWN_FAILURE, |
akaroml
Nov 29, 2017
Member
Too much indention.
Too much indention.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Signed-off-by: Jinbo Wang jinbwan@microsoft.com