★ wanayoo — archive 1999 https://github.com/microsoft/java-debug/pull/227Nouvelle recherche | Portail wanayoo
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix debug buttons disabled issue: send StoppedEvent after StepResponse/ContinueResponse #227

Merged
merged 3 commits into from Sep 19, 2018

Conversation

@testforstephen
Copy link
Contributor

@testforstephen testforstephen commented Sep 19, 2018

Signed-off-by: Jinbo Wang jinbwan@microsoft.com

It fixes the bug microsoft/vscode-java-debug#411 and #134

…/ContinuedResponse

Signed-off-by: Jinbo Wang <jinbwan@microsoft.com>
@testforstephen testforstephen requested review from andxu, yaohaizh and Eskibear Sep 19, 2018
return null;
}).join();
} finally {
synchronized (this) {

This comment has been minimized.

@yaohaizh

yaohaizh Sep 19, 2018

Avoid lock the whole object, use private object for lock.

This comment has been minimized.

@testforstephen

testforstephen Sep 19, 2018
Author Contributor

fixed.

@andxu
andxu approved these changes Sep 19, 2018
@testforstephen testforstephen merged commit 2106dbb into master Sep 19, 2018
3 checks passed
3 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
license/cla All CLA requirements met.
Details
@testforstephen testforstephen deleted the jinbo_bugfix branch Sep 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.