Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upGitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
add user settings #94
Conversation
| @@ -32,6 +33,8 @@ | |||
|
|
|||
| public static String CONFIG_LOG_LEVEL = "vscode.java.configLogLevel"; | |||
|
|
|||
| public static String UPDATE_USER_SETTINGS = "vscode.java.updateUserSettings"; | |||
akaroml
Nov 6, 2017
Member
We need to not confuse the user by providing the command vscode.java.updateUserSetting. It's actually debugger settings. So suggest making it "vscode.java.updateDebuggerSettings".
We need to not confuse the user by providing the command vscode.java.updateUserSetting. It's actually debugger settings. So suggest making it "vscode.java.updateDebuggerSettings".
| @@ -26,7 +26,7 @@ | |||
|
|
|||
| public class StringObjectFormatter extends ObjectFormatter implements IValueFormatter { | |||
| public static final String MAX_STRING_LENGTH_OPTION = "max_string_length"; | |||
| private static final int DEFAULT_MAX_STRING_LENGTH = 100; | |||
| private static final int DEFAULT_MAX_STRING_LENGTH = 200; | |||
akaroml
Nov 6, 2017
Member
Can I understand why 100 -> 200?
Can I understand why 100 -> 200?
andxu
Nov 7, 2017
Author
Collaborator
the default length is the length most users saw, the 100 is too small for normal cases like connections string, path, I would advise to use 256.
the default length is the length most users saw, the 100 is too small for normal cases like connections string, path, I would advise to use 256.
| if (showFullyQualifiedNames) { | ||
| options.put(SimpleTypeFormatter.QUALIFIED_CLASS_NAME_OPTION, showFullyQualifiedNames); | ||
| } | ||
| VariableUtils.applyFormatterOptions(options, evalArguments.format != null && evalArguments.format.hex, |
akaroml
Nov 6, 2017
Member
Do we need to apply the formatter options every time a evaluate request is processed? If the options stay inside VadiableUtils, then we can call it when a user actually changes the settings.
Do we need to apply the formatter options every time a evaluate request is processed? If the options stay inside VadiableUtils, then we can call it when a user actually changes the settings.
andxu
Nov 7, 2017
Author
Collaborator
The condition for generating options is also influenced by argument, not only user settings.
The condition for generating options is also influenced by argument, not only user settings.
| if (showFullyQualifiedNames) { | ||
| options.put(SimpleTypeFormatter.QUALIFIED_CLASS_NAME_OPTION, showFullyQualifiedNames); | ||
| } | ||
| VariableUtils.applyFormatterOptions(options, varArgs.format != null && varArgs.format.hex, false); |
akaroml
Nov 6, 2017
Member
Same here, do we really need to apply settings during processing a request?
Same here, do we really need to apply settings during processing a request?
…va-debug into andy_user_settings2
| Object valueObj = map.get(keyStr); | ||
| try { | ||
| switch (keyStr) { | ||
| case "show_hex": |
testforstephen
Nov 8, 2017
Contributor
Not consistent with the key on vscode user settings.
Not consistent with the key on vscode user settings.
|
|
||
| public final class UserSettings { | ||
| private static final Logger logger = Logger.getLogger(Configuration.LOGGER_NAME); | ||
| public static int maxStringLength = 0; |
yaohaizh
Nov 8, 2017
Not sure if it is a good idea to expose the (static) fields directly.
Not sure if it is a good idea to expose the (static) fields directly.
No description provided.