Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upFix issue when processing invalid tags #198
Merged
Conversation
When invalid tags are processed a null was returned causing all kind of issues in the normal behavior of this libary. As a solution a generic tag could be created. But that would just drop the error information in. Therefore a new tag was introduced, `invalidTag` the tag is just like the generic tag but does contain the error triggered during the creation of the tag. Which might help applications like phpdocumentor to display validation issues.
|
Reviewed; with a couple of suggestions for possible improvements |
f256f0b
into
master
14 of 15 checks passed
14 of 15 checks passed
Unit tests for PHP version 7.2 on ubuntu-latest
Unit tests for PHP version 7.2 on ubuntu-latest
Details
Unit tests for PHP version 7.3 on ubuntu-latest
Unit tests for PHP version 7.3 on ubuntu-latest
Details
Unit tests for PHP version 7.4 on ubuntu-latest
Unit tests for PHP version 7.4 on ubuntu-latest
Details
Unit tests for PHP version 7.2 on windows-latest
Unit tests for PHP version 7.2 on windows-latest
Details
Unit tests for PHP version 7.3 on windows-latest
Unit tests for PHP version 7.3 on windows-latest
Details
Unit tests for PHP version 7.4 on windows-latest
Unit tests for PHP version 7.4 on windows-latest
Details
Unit tests for PHP version 7.2 on macOS-latest
Unit tests for PHP version 7.2 on macOS-latest
Details
Unit tests for PHP version 7.3 on macOS-latest
Unit tests for PHP version 7.3 on macOS-latest
Details
Unit tests for PHP version 7.4 on macOS-latest
Unit tests for PHP version 7.4 on macOS-latest
Details
|
Thanks for the review. Updated the code and merged it to master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
When invalid tags are processed a null was returned causing all kind
of issues in the normal behavior of this libary. As a solution a generic tag
could be created. But that would just drop the error information in.
Therefore a new tag was introduced,
invalidTagthe tag is just like thegeneric tag but does contain the error triggered during the creation of the
tag. Which might help applications like phpdocumentor to display validation issues.