★ wanayoo — archive 1999 https://github.com/phpDocumentor/ReflectionDocBlock/pull/253Nouvelle recherche | Portail wanayoo
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Param: fix phpdoc with reference hint #253

Merged
merged 3 commits into from Aug 22, 2020
Merged

Conversation

@voku
Copy link
Contributor

@voku voku commented Aug 17, 2020 •

fix issue #251


This change is Reviewable

@voku
Copy link
Contributor Author

@voku voku commented Aug 21, 2020

@jaapio without this fix, I got many false-positive errors from Simple-PHP-Code-Parser when I for example try to check phpstorm-stubs

@jaapio
Copy link
Member

@jaapio jaapio commented Aug 21, 2020

Thanks, I will come back to you soon

@jaapio
Copy link
Member

@jaapio jaapio commented Aug 22, 2020

This looks good to me 👍
We might want to improve the growing if statement, but that's ok for now.

@jaapio jaapio merged commit 699b11e into phpDocumentor:master Aug 22, 2020
19 checks passed
19 checks passed
setup
Details
Unit tests
Details
Unit tests for PHP version 7.2 on ubuntu-latest
Details
Unit tests for PHP version 7.3 on ubuntu-latest
Details
Unit tests for PHP version 7.4 on ubuntu-latest
Details
Unit tests for PHP version 8.0 on ubuntu-latest Unit tests for PHP version 8.0 on ubuntu-latest
Details
Unit tests for PHP version 7.2 on windows-latest Unit tests for PHP version 7.2 on windows-latest
Details
Unit tests for PHP version 7.3 on windows-latest Unit tests for PHP version 7.3 on windows-latest
Details
Unit tests for PHP version 7.4 on windows-latest Unit tests for PHP version 7.4 on windows-latest
Details
Unit tests for PHP version 8.0 on windows-latest Unit tests for PHP version 8.0 on windows-latest
Details
Unit tests for PHP version 7.2 on macOS-latest
Details
Unit tests for PHP version 7.3 on macOS-latest
Details
Unit tests for PHP version 7.4 on macOS-latest
Details
Unit tests for PHP version 8.0 on macOS-latest Unit tests for PHP version 8.0 on macOS-latest
Details
codestyle
Details
phpstan
Details
Psalm (ubuntu-latest, 7.2)
Details
BC Check
Details
Scrutinizer 5 updated code elements
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.