Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upExpand AssertSameWithCountRule to support sizeof #8
Conversation
|
Hi, thanks for the PR, I found a few issues you should fix. |
| return [ | ||
| 'You should use assertCount($expectedCount, $variable) instead of assertSame($expectedCount, count($variable)).', | ||
| ]; | ||
| $method = strtolower($right->name->toString()); |
ondrejmirtes
Jan 1, 2018
Member
It's not a method, it's a functionName.
It's not a method, it's a functionName.
|
|
||
| if ($method === 'count') { | ||
| return [ | ||
| sprintf($message, 'count'), |
ondrejmirtes
Jan 1, 2018
Member
What about sprintf($message, $method) instead of this if/else?
What about sprintf($message, $method) instead of this if/else?
carusogabriel
Jan 1, 2018
Author
Contributor
Shouldn’t we verify if the function is count or sizeof? I followed the if that was here 😁
Shouldn’t we verify if the function is count or sizeof? I followed the if that was here
ondrejmirtes
Jan 1, 2018
Member
OK, just try to simplify the code somehow :)
OK, just try to simplify the code somehow :)
carusogabriel
Jan 1, 2018
Author
Contributor
Okay 👨💻
Okay
| @@ -36,10 +36,13 @@ public function processNode(Node $node, Scope $scope): array | |||
| if ( | |||
| $right instanceof Node\Expr\FuncCall | |||
| && $right->name instanceof Node\Name | |||
| && strtolower($right->name->toString()) === 'count' | |||
| && in_array(strtolower($right->name->toString()), ['count', 'sizeof']) | |||
carusogabriel
Jan 1, 2018
Author
Contributor
@ondrejmirtes Should I assigned the functionName inside the if, or is fine to repeat strtolower($right->name->toString()?
@ondrejmirtes Should I assigned the functionName inside the if, or is fine to repeat strtolower($right->name->toString()?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
As suggested in #7, I've expand👍
AssertSameWithCountRuleto supportcount's alias:sizeof