Fails to compile with icc #269

certik · 2020-08-19T18:22:21Z

I tried to build using Intel icc version 19.1.0.20191121 and the cmake succeeds to run:

$ cmake -DCMAKE_INSTALL_PREFIX:PATH=/builds/certik/truchas/scratch/python-install ../python-cmake-buildsystem
-- The C compiler identification is Intel 19.1.0.20191121
-- The ASM compiler identification is Intel
-- Found assembler: /opt/intel/bin/icc
-- Check for working C compiler: /opt/intel/bin/icc
-- Check for working C compiler: /opt/intel/bin/icc -- works
-- Detecting C compiler ABI info
...
-- Configuring done
-- Generating done
-- Build files have been written to: /builds/certik/truchas/scratch/python-build

But when I run make, it fails:

$ make -j8
...
[ 31%] Building C object CMakeBuild/libpython/CMakeFiles/pgen.dir/builds/certik/truchas/scratch/Python-3.6.7/Parser/grammar.c.o
/builds/certik/truchas/scratch/Python-3.6.7/Parser/grammar.c(37): error: expected an expression
          for (int j = 0; j < g->g_dfa[i].d_nstates; j++)
               ^
/builds/certik/truchas/scratch/Python-3.6.7/Parser/grammar.c(37): error: identifier "j" is undefined
          for (int j = 0; j < g->g_dfa[i].d_nstates; j++)
                          ^
compilation aborted for /builds/certik/truchas/scratch/Python-3.6.7/Parser/grammar.c (code 2)
make[2]: *** [CMakeBuild/libpython/CMakeFiles/pgen.dir/builds/certik/truchas/scratch/Python-3.6.7/Parser/grammar.c.o] Error 2

It looks like the icc compiler does not allow to define variables inside the for loop.

I don't know if icc is supported, but if not, then I would expect cmake to error out sooner. It might also be possible to fix the failures with a patch.

dand-oss · 2020-08-30T12:51:35Z

The problem is in the source code

If this is python dist source code, your options include

patch the python source for icc compatability
apply some options in cmake to allow icc to handle this
look in python for icc support in the python build

telamonian · 2020-09-17T00:04:13Z

Apparently, variable-definition-in-loop was a feature added to the C language as part of the C99 standard. Whereas even the most modern version of icc for some questionable reason defaults to "C90 plus GNU extensions". See the icc docs and this SO thread.

So it looks like the fix for this will be to set the -std=c99 CFLAG for intel toolchain builds

telamonian · 2020-09-17T00:12:02Z

Probably will need something in a CMake file like:

if(${CMAKE_C_COMPILER_ID} MATCHES "Intel")
    set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} -std=c99")
endif(${CMAKE_C_COMPILER_ID} MATCHES "Intel")

relevant cmake docs

Edit:

Most of the relevant code was already in the main CMakeLists.txt:

python-cmake-buildsystem/CMakeLists.txt

Lines 410 to 428 in a1ce7c2

    
           # Set cflags used by all components 
        
           if(CMAKE_C_COMPILER_ID MATCHES GNU) 
        
               if(PY_VERSION VERSION_EQUAL "3.6" OR PY_VERSION VERSION_GREATER "3.6") 
        
                   append_if_absent(CMAKE_C_FLAGS "-std=c99") 
        
               endif() 
        
               append_if_absent(CMAKE_C_FLAGS "-Wall") 
        
               append_if_absent(CMAKE_C_FLAGS "-Wstrict-prototypes") 
        
               append_if_absent(CMAKE_C_FLAGS "-fno-strict-aliasing") 
        
               append_if_absent(CMAKE_C_FLAGS "-fwrapv") 
        
               append_if_absent(CMAKE_C_FLAGS "-g") 
        
           elseif(CMAKE_C_COMPILER_ID MATCHES Clang) 
        
               append_if_absent(CMAKE_C_FLAGS "-Wall") 
        
               append_if_absent(CMAKE_C_FLAGS "-g") 
        
           elseif(CMAKE_C_COMPILER_ID MATCHES Intel) 
        
               append_if_absent(CMAKE_C_FLAGS "-Wall") 
        
               append_if_absent(CMAKE_C_FLAGS "-no-ansi-alias") 
        
           elseif(CMAKE_C_COMPILER_ID MATCHES PGI) 
        
               append_if_absent(CMAKE_C_FLAGS "-alias=traditional") 
        
           endif()

just had to go looking for it


          Fix python-cmake-buildsystem#269: add C99 flag for intel compilers

The intel C compiler [defaults to `-std=gnu98`](https://software.intel.com/content/www/us/en/develop/documentation/cpp-compiler-developer-guide-and-reference/top/compiler-reference/compiler-options/compiler-option-details/language-options/std-qstd.html#std-qstd_GUID-338F4C2A-560C-4338-8ACF-C4B022A7C865), which apparently causes problems with recent cpython source. Judging by the existing code in `CMakeLists.txt` and [this issue on the core cpython repo](python/cpython#568), somewhere around cpy3.6 cpython moved on to C99. This PR ensures that if intel compilers are being used on cpy>=3.6 source, the `-std=C99` flag will be added

telamonian · 2020-09-17T00:33:16Z

@certik I did a fix PR at #271. Can you please try it out?

telamonian linked a pull request that will close this issue Sep 17, 2020

Fix #269: add C99 flag for intel compilers #271

Open

python-cmake-buildsystem / python-cmake-buildsystem

Fails to compile with icc #269

Fails to compile with icc #269

certik commented Aug 19, 2020

dand-oss commented Aug 30, 2020

telamonian commented Sep 17, 2020 •

edited

telamonian commented Sep 17, 2020 •

edited

telamonian commented Sep 17, 2020

python-cmake-buildsystem / python-cmake-buildsystem

Join GitHub today

Fails to compile with icc #269

Fails to compile with icc #269

Comments

certik commented Aug 19, 2020

dand-oss commented Aug 30, 2020

telamonian commented Sep 17, 2020 • edited

telamonian commented Sep 17, 2020 • edited

Edit:

telamonian commented Sep 17, 2020

Essential cookies

Always active

Analytics cookies

telamonian commented Sep 17, 2020 •

edited

telamonian commented Sep 17, 2020 •

edited