★ wanayoo — archive 1999 https://github.com/reactphp/filesystem/pull/29Nouvelle recherche | Portail wanayoo
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No need to run composer self-update, travis does that for us #29

Merged
merged 1 commit into from May 29, 2018

Conversation

@WyriHaximus
Copy link
Member

@WyriHaximus WyriHaximus commented May 28, 2018

No description provided.

@WyriHaximus WyriHaximus added this to the v0.1.1 milestone May 28, 2018
@WyriHaximus WyriHaximus requested review from jsor and clue May 28, 2018
@jsor
jsor approved these changes May 28, 2018
@clue
clue approved these changes May 28, 2018
Copy link
Member

@clue clue left a comment

No objections. May as well clean up the other dead code from this file 👍

@WyriHaximus WyriHaximus merged commit 7e5b70f into reactphp:master May 29, 2018
1 check failed
1 check failed
continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
@WyriHaximus
Copy link
Member Author

@WyriHaximus WyriHaximus commented May 29, 2018

@clue Or enabled that dead code, I rather have tests for this package running on all event loops. In the end I'd be interested in support event loop specific adapters as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants