★ wanayoo — archive 1999 https://github.com/realpython/materials/pull/100Nouvelle recherche | Portail wanayoo
Skip to content

/ materials

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removed sqlite forth / #100

Open
wants to merge 2 commits into
base: master
from
Open

removed sqlite forth / #100

wants to merge 2 commits into from

Conversation

@KleinerKobold
Copy link

KleinerKobold commented Jan 30, 2020

On windows systems sqlite://// don't work.
Would be nice to switch to pathlib instead of os.path

Where to put new files:

  • New files should go into a top-level subfolder, named after the article slug. For example: my-awesome-article

How to merge your changes:

  1. Make sure the CI code style tests all pass (+ run the automatic code formatter if necessary).
  2. Find an RP Team member on Slack and ask them to review & approve your PR.
  3. Once the PR has one positive ("approved") review, GitHub lets you merge the PR.
  4. 🎉
@KleinerKobold
removed sqlite forth /
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
6f769bb 
On windows systems sqlite://// don't work.
Would be nice to switch to pathlib instead of os.path
@ghost
ghost reviewed Feb 27, 2020
View changes
Copy link

ghost left a comment

m
@ghost
ghost approved these changes Feb 27, 2020
View changes
Copy link

ghost left a comment

ok
@dbader
Copy link
Member

dbader commented Apr 24, 2020

/cc @writeson
@dbader dbader requested a review from writeson Apr 24, 2020
@dbader
Merge branch 'master' into patch-1
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
264d1a4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@writeson writeson

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@KleinerKobold @dbader
You can’t perform that action at this time.